Starts using the --source flag to compile the dart registrant.#98046
Merged
gaaclarke merged 10 commits intoflutter:masterfrom Mar 2, 2022
Merged
Starts using the --source flag to compile the dart registrant.#98046gaaclarke merged 10 commits intoflutter:masterfrom
--source flag to compile the dart registrant.#98046gaaclarke merged 10 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
gaaclarke
force-pushed
the
use-source-dart-registrant
branch
from
11dd2ab to
30972d7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gaaclarke
force-pushed
the
use-source-dart-registrant
branch
from
2f4c1b8 to
e8c4c68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
gaaclarke
force-pushed
the
use-source-dart-registrant
branch
11 times, most recently
from
4bc3b73 to
3499ec3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
8 tasks
gaaclarke
force-pushed
the
use-source-dart-registrant
branch
from
468b1cc to
989ebd7
Compare
flutter-dashboard
bot
added
the
c: contributor-productivity
gaaclarke
commented
Feb 14, 2022
Member
Author
|
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
This was referenced Mar 4, 2022
This was referenced Mar 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hack we did previously to shadow the main entrypoint wasn't working on release builds. Now that Dart supports the
--sourceflag we can avoid shadowing main which fixes the issue and is a more clear solution.fixes #91841
companion engine pr: flutter/engine#31418
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.