Skip to content

Improve container widget#98389

Merged
fluttergithubbot merged 13 commits intoflutter:masterfrom
r-mzy47:improve-container-widget
Mar 4, 2022
Merged

Improve container widget#98389
fluttergithubbot merged 13 commits intoflutter:masterfrom
r-mzy47:improve-container-widget

Conversation

@r-mzy47
Copy link

@r-mzy47 r-mzy47 commented Feb 14, 2022 •
edited
Loading

in Container Widget when the child parameter is null and constraints is not Tight, there is no need to add the [Align] widget when the alignment parameter is provided.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 14, 2022
goderbauer
goderbauer reviewed Feb 16, 2022
View reviewed changes
@r-mzy47 r-mzy47 requested a review from goderbauer February 18, 2022 15:16
goderbauer
goderbauer approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @r-mzy47 welcome! Thanks for the contribution!
LGTM

@goderbauer
Copy link
Member

goderbauer commented Mar 2, 2022

@r-mzy47 Looks like the tests got stuck on this PR and for some reason I cannot restart them. Could you push and empty commit to this PR or rebase it to the latest master to re-trigger the tests? Thanks and sorry for the inconvenience.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_canvaskit_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@r-mzy47
Copy link
Author

r-mzy47 commented Mar 4, 2022

@goderbauer I have pushed an empty commit. But still, there are some pending tests. In addition, there are some failures added. have I done something wrong?

@goderbauer
Copy link
Member

goderbauer commented Mar 4, 2022

Looks like its an unrelated failure. Should be fixed if you rebase this branch to the latest master.

@r-mzy47 r-mzy47 force-pushed the improve-container-widget branch from 2e6805b to bac15fe Compare March 4, 2022 21:07
@r-mzy47 r-mzy47 requested a review from goderbauer March 4, 2022 22:40
goderbauer
goderbauer approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
bf50793
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
6dfb99d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
ab70592
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
6bdc1e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
9b8a38f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
127a616
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
4bfcc56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
29034b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
e4211da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
d61caaa Improve container widget (flutter/flutter#98389)
c3109d2
This was referenced Mar 8, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r-mzy47 @goderbauer @fluttergithubbot @Piinks