Skip to content

Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced#98539

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
Piinks:maxLength
Mar 8, 2022
Merged

Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced#98539
fluttergithubbot merged 5 commits intoflutter:masterfrom
Piinks:maxLength

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022 •
edited
Loading

This removes maxLengthEnforced from

  • CupertinoTextField
  • TextField
  • TextFormField

This deprecated property has reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Feb 16, 2022
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@Piinks Piinks changed the title [WIP]Remove deprecated [CupertinoTextField, TextField, TextFormField] maxLengthEnforced [WIP]Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 16, 2022
@Piinks Piinks changed the title [WIP]Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced [WIP] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 16, 2022
@Piinks Piinks changed the title [WIP] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced Feb 18, 2022
@Piinks Piinks requested a review from justinmc February 18, 2022 21:33
@skia-gold
Copy link

skia-gold commented Feb 19, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/98539

@Piinks
Copy link
Contributor Author

Piinks commented Mar 3, 2022

This is pending one last customer change.

@Piinks Piinks requested a review from goderbauer March 3, 2022 22:37
goderbauer
goderbauer approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 7, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

justinmc
justinmc approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice, thanks for removing this!

It looks like there are Google test failures, I think they'll just need to be migrated to maxLengthEnforcement. Let me know if I can help with that.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 7, 2022

Thank you! I have a cl out for review that will take care of the last one from Google testing.

@fluttergithubbot fluttergithubbot merged commit 5ae4885 into flutter:master Mar 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
1de0421 
…d maxLengthEnforced (flutter/flutter#98539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
651394b 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
f48d15c 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
37df314 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
8a247ab 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
6595b2e 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
9844c41 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
083cc64 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
654eddb 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
cc1dcc5 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
1d2b88a 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
6efd6db 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
daaea23 
…d maxLengthEnforced (flutter/flutter#98539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
5ae4885 Remove deprecated CupertinoTextField, TextField, TextFormFiel…
c86e603 
…d maxLengthEnforced (flutter/flutter#98539)
This was referenced Mar 10, 2022
Closed
Closed
Closed
Closed
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Piinks @skia-gold @fluttergithubbot @justinmc @goderbauer