Skip to content

Android Q transition by default#98559

Merged
dnfield merged 1 commit intoflutter:masterfrom
AlexV525:zoom-page-transition-by-default
Mar 25, 2022
Merged

Android Q transition by default#98559
dnfield merged 1 commit intoflutter:masterfrom
AlexV525:zoom-page-transition-by-default

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Feb 16, 2022

Continue from #96375, fix #43277.

Breaking change note: flutter/website#6646.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AlexV525 AlexV525 requested review from Hixie and dnfield February 16, 2022 03:47
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 16, 2022
This was referenced Feb 16, 2022
Merged
Merged
@dnfield
Copy link
Contributor

dnfield commented Mar 25, 2022

Once cl/437273800 lands we can merge this.

@dnfield
Copy link
Contributor

dnfield commented Mar 25, 2022

Also, this patch is expected to update ~10 golden file tests, see internal cl/430569118. @angjieli @itsjustkevin @renyou FYI

dnfield
dnfield approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Mar 25, 2022

Internal test update has landed, this is good to go.

@dnfield dnfield merged commit c82ddd3 into flutter:master Mar 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
dc6bffb
zanderso added a commit that referenced this pull request Mar 25, 2022
@zanderso
Revert "✨ Android Q transition by default (#98559)"
dfa75af 
This reverts commit c82ddd3.
@zanderso zanderso mentioned this pull request Mar 25, 2022
Merged
dnfield pushed a commit that referenced this pull request Mar 25, 2022
@zanderso
Revert "✨ Android Q transition by default (#98559)" (#100799)
bfa272a 
This reverts commit c82ddd3.
@AlexV525 AlexV525 mentioned this pull request Mar 26, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
7e2e32d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
71e5db7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
db8013e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
b708efc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
2717df3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
018d1ca
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
c82ddd3 ✨ Android Q transition by default (flutter/flutter#98559)
aed43d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Android 10 Activity Animation the default animation

2 participants

@AlexV525 @dnfield