Skip to content

Remove "beta-quality" for Windows#98614

Merged
cbracken merged 1 commit intoflutter:masterfrom
timsneath:windows-nobeta
Feb 18, 2022
Merged

Remove "beta-quality" for Windows#98614
cbracken merged 1 commit intoflutter:masterfrom
timsneath:windows-nobeta

Conversation

@timsneath
Copy link
Contributor

@timsneath timsneath commented Feb 16, 2022 •
edited
Loading

Removes "beta-quality" label now that Windows has shipped.

List which issues are fixed by this PR. You must list at least one issue.
Fixes #98610

If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 16, 2022
@timsneath timsneath requested a review from cbracken February 16, 2022 20:27
@timsneath timsneath added a: quality A truly polished experience platform-windows Building on or for Windows specifically labels Feb 16, 2022
christopherfujino
christopherfujino approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino mentioned this pull request Feb 17, 2022
Closed
cbracken
cbracken approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@cbracken cbracken merged commit 5c7ca2e into flutter:master Feb 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
9407aa7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
273dccb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
1b1940a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
7ce4ae4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
a1f6068
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
5c7ca2e Remove "beta-quality" for Windows (flutter/flutter#98614)
8ba8e35
@timsneath timsneath deleted the windows-nobeta branch February 23, 2022 00:31
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Remove "beta-quality" for Windows (flutter#98614)
900919e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: quality A truly polished experience platform-windows Building on or for Windows specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter tool incorrectly suggests windows desktop support is beta-quality

3 participants

@timsneath @cbracken @christopherfujino