Reland "Add more tests to slider to avoid future breakages (#98772)"#98936
Reland "Add more tests to slider to avoid future breakages (#98772)"#98936fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
/cc @zanderso @jonahwilliams My understanding is that all golden images on this PR are properly triaged and all checks are passing. So, it really shouldn't cause any post-submit failures. If it does, something is broken in our process (and instead of rolling back, we should triage those golden images post submit). Well, and we need to fix whatever is broken in the process to avoid this in the future. |
|
|
||
| await expectLater( | ||
| find.byType(MaterialApp), | ||
| matchesGoldenFile('slider_start_text_scale_1_width_0'), |
There was a problem hiding this comment.
These all need to end with .png
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
These failed in post submit because without .png they all resolved to the same test name material, but they are all different images.
|
Gold has detected about 8 new digest(s) on patchset 2. |
4 participants
This reverts commit 9aed298.
It's not super-clear to me why this change failed in post-submit. All checks on the original PR #98772 were green and the new images were properly triaged on the gold dashboard prior to submitting the PR.
@Piinks Is there anything else I need to do to land this cleanly?