Clean up ClipboardStatusNotifier#98951
Merged
chunhtai merged 4 commits intoflutter:masterfrom Feb 23, 2022
Merged
Conversation
flutter-dashboard
bot
added
a: text input
chunhtai
commented
Feb 23, 2022
| void handleCut(TextSelectionDelegate delegate, ClipboardStatusNotifier? clipboardStatus) { | ||
| void handleCut(TextSelectionDelegate delegate) { | ||
| delegate.cutSelection(SelectionChangedCause.toolbar); | ||
| clipboardStatus?.update(); |
Contributor
Author
There was a problem hiding this comment.
It should be the delegate's job to call update on clipboardStatus since it is the owner. There may also be use case that cutSelection does not write thing into clipboard due to other short-circuited condition
| void handleCopy(TextSelectionDelegate delegate, ClipboardStatusNotifier? clipboardStatus) { | ||
| void handleCopy(TextSelectionDelegate delegate) { | ||
| delegate.copySelection(SelectionChangedCause.toolbar); | ||
| clipboardStatus?.update(); |
|
|
||
| bool _disposed = false; | ||
| /// True if this instance has been disposed. | ||
| bool get disposed => _disposed; |
Contributor
Author
There was a problem hiding this comment.
This is used by the listeners to decide whether they should call removeListener when they are disposed
This is no longer needed because removeListener is allowed to be called after it is disposed now
Contributor
There was a problem hiding this comment.
I'm happy to see this going away 👍
justinmc
approved these changes
Feb 23, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
This looks cleaner and I agree we shouldn't have the selection toolbar depend on the clipboard status unless it actually uses "paste".
| Widget build(BuildContext context) { | ||
| // Don't render the menu until the state of the clipboard is known. | ||
| if (widget.handlePaste != null && _clipboardStatus!.value == ClipboardStatus.unknown) { | ||
| if (widget.handlePaste != null && widget.clipboardStatus?.value == ClipboardStatus.unknown) { |
Contributor
There was a problem hiding this comment.
What if clipboardStatus is null?
Contributor
Author
There was a problem hiding this comment.
if it is null it will skip this if condition and still build the toolbar. We only want to skip if we need to build the paste button( has handlePaste and has _clipboardStatus) and the status is unknown
|
|
||
| bool _disposed = false; | ||
| /// True if this instance has been disposed. | ||
| bool get disposed => _disposed; |
Contributor
There was a problem hiding this comment.
I'm happy to see this going away 👍
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 23, 2022
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 1, 2022
This reverts commit c74a646.
chunhtai
added a commit
that referenced
this pull request
Mar 1, 2022
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 1, 2022
…utter#99361)" This reverts commit 64d9ea6.
renyou
pushed a commit
to renyou/flutter
that referenced
this pull request
Mar 2, 2022
) This reverts commit c74a646.
renyou
added a commit
that referenced
this pull request
Mar 2, 2022
This reverts commit c74a646. Co-authored-by: chunhtai <[email protected]>
renyou
added a commit
that referenced
this pull request
Mar 2, 2022
* Revert "Clean up ClipboardStatusNotifier (#98951)" (#99361) This reverts commit c74a646. * Revert "Draggable can be accepted when the data is null" (#99419) Co-authored-by: chunhtai <[email protected]> Co-authored-by: Kate Lovett <[email protected]>
renyou
added a commit
that referenced
this pull request
Mar 3, 2022
* Revert "Clean up ClipboardStatusNotifier (#98951)" (#99361) This reverts commit c74a646. * Revert "Draggable can be accepted when the data is null" (#99419) * Cherrypick engine to 32395e4ab410df3b7d05b0f90d2601c5c7d27024 Co-authored-by: chunhtai <[email protected]> Co-authored-by: Kate Lovett <[email protected]>
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* Clean up ClipboardStatusNotifier * fix * fix test * more refactaaaaagit add .
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
) This reverts commit c74a646.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation of this change is that other widget no longer need to create ClipboardStatusNotifier to use SelectionOverlay if they don't need paste functionality. Furthermore, it should not be TextSelectionOverlay's job to refresh the ClipboardStatus to notify itself, it should be whoever handles cut/paste to refresh the clipboard status. It also allows more flexibility if one does not rely on system clipboard.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.