Make popup menus avoid display features#98981
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Mar 28, 2022
Merged
Make popup menus avoid display features#98981fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
This was referenced Feb 23, 2022
Contributor
Author
|
This was split from #92909 as popup menus have less in common with modal routes than I initially considered. @Piinks @goderbauer |
HansMuller
requested review from
Piinks and
gspencergoog
and removed request for
gspencergoog
Piinks
added
a: layout
Piinks
reviewed
Mar 3, 2022
Contributor
Author
|
@Piinks Please let me know if there are any other changes I should make. |
Piinks
approved these changes
Mar 22, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Thank you for the updates! And thank you for managing this marathon of changes to enable these features. 🎉
Contributor
|
cc @goderbauer for secondary review, please and thanks. :) |
Contributor
|
@andreidiaconu can you rebase this PR? It looks like the G testing shard is stuck here, and the un-sticking tool is not fixing it. |
andreidiaconu
force-pushed
the
foldable_support_popup_menu
branch
from
2c625b7 to
2c9a0d4
Compare
Contributor
Author
Rebased |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes popup menus avoid overlapping display features.
Here is an example of showing a popup menu on one of the screens, instead of the middle of the screen (where the example device has a display feature):
This is split from a larger PR for foldable support in order to make it easier to review (#77156).
Issues that will be fixed by this PR:
Pre-launch Checklist
///).