Revert "Remove redundant hide handles API from TextSelectionDelegate …#99008
Merged
chunhtai merged 1 commit intoflutter:masterfrom Feb 23, 2022
Merged
Revert "Remove redundant hide handles API from TextSelectionDelegate …#99008chunhtai merged 1 commit intoflutter:masterfrom
chunhtai merged 1 commit intoflutter:masterfrom
Conversation
…lutter#98944)" This reverts commit 94f6fd6.
flutter-dashboard
bot
added
a: text input
justinmc
approved these changes
Feb 23, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
Revert LGTM 👍 I guess it did end up being a breaking change.
Contributor
Author
|
Yes, the devtool uses this API to write their own selectionControl for SelectableText, since there isn't a API to hide toolbar from in SelectableText, this is the only way for them to do it. I think I will keep this API for now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 23, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…lutter#98944)" (flutter#99008) This reverts commit 94f6fd6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#98944)"
This reverts commit 94f6fd6.
internal test failure
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.