Skip to content

Add material localizations for keyboard keys used for shortcut descriptions in menus.#99020

Merged
gspencergoog merged 2 commits intoflutter:masterfrom
gspencergoog:menu_bar_localizations
Mar 3, 2022
Merged

Add material localizations for keyboard keys used for shortcut descriptions in menus.#99020
gspencergoog merged 2 commits intoflutter:masterfrom
gspencergoog:menu_bar_localizations

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Feb 23, 2022

Description

This change adds some localizations for keyboard keys that will be used in creating shortcut descriptions in menus.

Related Issues

Tests

  • Added tests for new strings.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 23, 2022
@jmagman
Copy link
Member

jmagman commented Feb 24, 2022

Unfortunately you hit #99036, please rebase onto #99037.

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Feb 24, 2022

@jmagman , thanks, will do!

HansMuller
HansMuller approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Currently the analyzer is complaining about trailing white space.

@gspencergoog gspencergoog force-pushed the menu_bar_localizations branch from 77481e4 to a4c3230 Compare February 24, 2022 20:25
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 25, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog force-pushed the menu_bar_localizations branch from a4c3230 to 8b14501 Compare February 25, 2022 23:03
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 26, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog force-pushed the menu_bar_localizations branch from 8b14501 to 6f6421d Compare March 2, 2022 17:38
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Mar 3, 2022

Merging even though "Google Testing" is red, since this PR contains files that are too large for FROB to handle, so it's not even running the tests.

@gspencergoog gspencergoog merged commit 940986e into flutter:master Mar 3, 2022
@gspencergoog gspencergoog deleted the menu_bar_localizations branch March 3, 2022 02:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
7c7e1fb 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
fc01163 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
2fcb16b 
…t descriptions in menus. (flutter/flutter#99020)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
8848301 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
c861831 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
9858a65 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
4ea64e7 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
fe7d72b 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
8284af3 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
7cecec7 
…t descriptions in menus. (flutter/flutter#99020)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
940986e Add material localizations for keyboard keys used for shortcu…
931e16e 
…t descriptions in menus. (flutter/flutter#99020)
This was referenced Mar 6, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gspencergoog @jmagman @fluttergithubbot @HansMuller