Skip to content

Wait for ios-deploy stdout before closing logLine stream#99041

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
jmagman:close-logs
Feb 25, 2022
Merged

Wait for ios-deploy stdout before closing logLine stream#99041
fluttergithubbot merged 2 commits intoflutter:masterfrom
jmagman:close-logs

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 24, 2022 •
edited
Loading

Also migrate the ios_deploy_test file to use the emits matcher instead of checking the values from Stream.toList()

Fixes #99021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 24, 2022
@jmagman jmagman self-assigned this Feb 24, 2022
jmagman
jmagman commented Feb 24, 2022
View reviewed changes
packages/flutter_tools/test/general.shard/ios/ios_deploy_test.dart
interfaceType: IOSDeviceConnectionInterface.network,
);

expect(iosDeployDebugger.logLines, emits('Did finish launching.'));
Copy link
Member Author

@jmagman jmagman Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped this test file to use the emits matcher instead of Stream.toList()

christopherfujino
christopherfujino approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 9369bd3 into flutter:master Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
8edfc53 
…tter/flutter#99041)
@jmagman jmagman deleted the close-logs branch February 25, 2022 03:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
1901b45 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
3a49982 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
36b99e7 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
7b099a5 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
307bd9c 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
027acd0 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
b9bf37c 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
414976d 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
9f00c88 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
3ae98b4 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
bcd2535 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
67d47e0 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
05e2d57 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
d5d865d 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
6e8ffb7 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
5f00bfe 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
546e689 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
cfe0f04 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
a7a3383 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
6967a4c 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
f8ba83b 
…tter/flutter#99041)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
9369bd3 Wait for ios-deploy stdout before closing logLine stream (flu…
bede5e7 
…tter/flutter#99041)
@jmagman jmagman mentioned this pull request Mar 5, 2022
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Wait for ios-deploy stdout before closing logLine stream (flutter#99041)
17545ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad state: Cannot add new events after calling close, IOSDeviceLogReader.debuggerStream= > _BroadcastStreamController.add

3 participants

@jmagman @christopherfujino @fluttergithubbot