Adds a Listview tile select example#99165

Merged

fluttergithubbot merged 16 commits intoflutter:masterfrom

maheshj01:listview_sample

Mar 8, 2022

Member

maheshj01 commented Feb 25, 2022 •

edited by Piinks

Loading

This PR fixes #12882 and adds a listview tile example which shows a List of ListTile

long press and select a listTile
switch between grid view and listView (while persisting state)
select all ListTiles of list
unselect all ListTiles of list

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks reviewed

View reviewed changes

Contributor

Piinks left a comment

Thanks for writing this - and including a test! :)

Looks like the file names need a number according to the the other example files.

Also, this won't show up in the api docs if it is not included somewhere, maybe in ListTile?

Here is an example:

flutter/packages/flutter/lib/src/widgets/scroll_view.dart

Line 514 in 9cb60c9

    
           /// ** See code in examples/api/lib/widgets/scroll_view/custom_scroll_view.1.dart **

flutter-dashboard bot added d: api docs d: examples documentation f: scrolling c: contributor-productivity labels

Member Author

maheshj01 commented Mar 1, 2022

Thanks for the review @Piinks I have renamed the file and linked the example in the comments here.

flutter/packages/flutter/lib/src/widgets/scroll_view.dart

Lines 1007 to 1012 in 9cb60c9

    
           /// ## Selection of list items 
        
           /// 
        
           /// `ListView` has no built-in notion of a selected item or items. For a small 
        
           /// example of how a caller might wire up basic item selection, see 
        
           /// [ListTile.selected]. 
        
           ///

I thought this was the right place Since this section already talks about selecting ListItems. Let me know if you think this should be included somewhere else.

Thanks

Piinks reviewed

View reviewed changes

Contributor

Piinks left a comment

Thanks for the update!

packages/flutter/lib/src/widgets/scroll_view.dart Outdated

Comment on lines 1012 to 1013

Contributor

Piinks Mar 2, 2022

This should be included in a {@tool dartpad... like the other example. :)
That is what makes the sample in the api docs interactive.

Member Author

maheshj01 Mar 2, 2022

Sure thing !
Done.

Piinks reviewed

View reviewed changes

packages/flutter/lib/src/widgets/scroll_view.dart Outdated Show resolved Hide resolved

examples/api/lib/widgets/scroll_view/listview_select.1.dart Outdated

Contributor

Piinks Mar 2, 2022

Suggested change

      
            // Flutter code sample for ListView
          
            // Flutter code sample for ListTile selection.

Member Author

maheshj01 Mar 3, 2022

Done

examples/api/lib/widgets/scroll_view/listview_select.1.dart Outdated

Comment on lines 90 to 91

Contributor

Piinks Mar 2, 2022

Does this get clipped, or does the text all fit in the app bar?

Member Author

maheshj01 Mar 3, 2022

The text fits in appBar the title has ellipses

Contributor

Piinks Mar 3, 2022

The clipping of the title is not ideal, can you update to something shorter?

Member Author

maheshj01 Mar 4, 2022

Sure, Changed to "ListTile selection"

examples/api/lib/widgets/scroll_view/listview_select.1.dart Outdated

Comment on lines 126 to 130

Contributor

Piinks Mar 2, 2022

Nit: Is this dart format? It looks a bit off.

Member Author

maheshj01 Mar 3, 2022

I guess yes, I am using vs code which uses the default formatter which formats the code on save.

Member Author

maheshj01 Mar 3, 2022

Probably this is resolved now

examples/api/lib/widgets/scroll_view/listview_select.1.dart Outdated

Contributor

Piinks Mar 2, 2022

Can we avoid using ignores in sample code? We consider ignores in code as technical debt, things that need to be fixed. Since this is meant to be instructive it probably should not have an ignore.

Member Author

maheshj01 Mar 3, 2022

If I remove that the linter warns

This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: GridBuilder.isSelectionMode

to fix this warning if I make isSelectionMode as final then I get a syntax error on line 167, since I am reassiging the value

widget.isSelectionMode = true;

if I mark isSelectionMode as late I get a warning to make GrIdBuilder const if I mark it as const I get syntax error to remove late

Can't have a late final field in a class with a generative const constructor.
Try removing the 'late' modifier, or don't declare 'const' constructors.

and this continues in a cycle. This is same for ListBuilder as the widgets are Identical.

if this is necessary to get rid of the ignores I can fix that by toggling isSelectionMode out of the widget.

Member Author

maheshj01 Mar 3, 2022

updated code sample

examples/api/lib/widgets/scroll_view/listview_select.1.dart Outdated

Contributor

Piinks Mar 2, 2022

Same here

Member Author

maheshj01 Mar 3, 2022

This is fixed now

maheshj01 and others added 16 commits

March 7, 2022 23:02


          add listview tile select example

0818c24


          add basic tests

da0fdbb


          remove trailing space

73ebac7


          add a license header to test file

db00673


          add numbering to file names

e4a9f3b


          link example in doc comments

59bd00a


          add interactive example

9021e11


          remove trailing space

cd09430


          Nit: scrollview docs

bfff1fb

Co-authored-by: Kate Lovett <[email protected]>


          Link sample to Gridview docs

e747443


          update code sample description

651bfed


          renamed variable for better readability

71e65d2


          Remove leading when selection mode is false

55428b4


          change Textbutton color to white

6c3e880


          refactor code sample

e8160e2


          update title

7b9d810

Piinks approved these changes

View reviewed changes

Contributor

Piinks left a comment

Thank you!

Piinks added the waiting for tree to go green label

fluttergithubbot merged commit 67a0df4 into flutter:master

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 67a0df41cd7f (93 revisions) flutter/packages#1118

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

44f94eb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

7bf0225

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to cb9e9a37860c (127 revisions) flutter/packages#1162

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to bb2cca5f59a1 (128 revisions) flutter/packages#1163

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

a091758

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to bcb381598507 (129 revisions) flutter/packages#1164

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

f68e22b

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to ce341c871dd2 (130 revisions) flutter/packages#1166

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

412ddf4

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 57aa49028db7 (132 revisions) flutter/packages#1167

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

061ca86

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 57aa49028db7 (132 revisions) flutter/packages#1168

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

8558d3d

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 57aa49028db7 (132 revisions) flutter/packages#1169

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

d6f691b

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 9c4976e4e7a1 (133 revisions) flutter/packages#1170

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

dfd4666

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 48172589e5ac (134 revisions) flutter/packages#1171

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

c58c1a6

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 0dfb656e28b9 (135 revisions) flutter/packages#1172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

437d080

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 21320a1da5b0 (136 revisions) flutter/packages#1173

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

aa7ecdd

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to 7bd067ab2487 (137 revisions) flutter/packages#1174

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

c4e7efb

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 38dbbb17f8ce to dc928989f4d5 (138 revisions) flutter/packages#1175

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

8b87b80

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

a0cce14

ditman added a commit to ditman/flutter-packages that referenced this pull request


          Roll Flutter from 38dbbb1 to 0dfb656 (135 revisions)

a35219d

Roll Flutter from 38dbbb1 to 0dfb656 (135 revisions)

flutter/flutter@38dbbb1...0dfb656

2022-03-10 [email protected] Roll Engine from bf2bf3a3fd2b to 6b1a24b1a108 (10 revisions) (flutter/flutter#99917)
2022-03-10 [email protected] Roll Plugins from eb6ad34 to 20e231b (8 revisions) (flutter/flutter#99913)
2022-03-10 [email protected] Roll Engine from 2c1816b39127 to bf2bf3a3fd2b (3 revisions) (flutter/flutter#99887)
2022-03-10 [email protected] Migrate NavigationRail to Material 3. (flutter/flutter#99171)
2022-03-10 [email protected] Remove expired ThemeData deprecations (flutter/flutter#98578)
2022-03-09 [email protected] Roll Engine from 09a11d137953 to 2c1816b39127 (3 revisions) (flutter/flutter#99878)
2022-03-09 [email protected] [ci.yaml] Remove unused benchmark property (flutter/flutter#99843)
2022-03-09 [email protected] [Material] Create an InkSparkle splash effect that matches the Material 3 ripple effect (flutter/flutter#99731)
2022-03-09 [email protected] Remove deprecated RenderEditable.onSelectionChanged (flutter/flutter#98582)
2022-03-09 [email protected] Marks Mac_ios post_backdrop_filter_perf_ios__timeline_summary to be flaky (flutter/flutter#99856)
2022-03-09 [email protected] Roll Engine from 6d7bcc9e577c to 09a11d137953 (3 revisions) (flutter/flutter#99870)
2022-03-09 [email protected] [tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates (flutter/flutter#94509)
2022-03-09 [email protected] First pass at using platform abstraction for plugins (flutter/flutter#92672)
2022-03-09 [email protected] Fix `ColorScheme.shadow` to default to black even for dark themes. (flutter/flutter#99722)
2022-03-09 [email protected] Roll Engine from a0963f14b67d to 6d7bcc9e577c (3 revisions) (flutter/flutter#99847)
2022-03-09 [email protected] Updated tokens to v0.90. (flutter/flutter#99782)
2022-03-09 [email protected] Marks Mac_ios backdrop_filter_perf_ios__timeline_summary to be unflaky (flutter/flutter#99836)
2022-03-09 [email protected] updateEditingValueWithDeltas snippet docs fix (flutter/flutter#99570)
2022-03-09 [email protected] Roll Engine from 9362061fbb79 to a0963f14b67d (1 revision) (flutter/flutter#99838)
2022-03-09 [email protected] Roll Plugins from b906ea5 to eb6ad34 (9 revisions) (flutter/flutter#99828)
2022-03-09 [email protected] Update visibility of methods for internal use (flutter/flutter#98124)
2022-03-09 [email protected] Roll Engine from 621c88dc2d13 to 9362061fbb79 (6 revisions) (flutter/flutter#99809)
2022-03-09 [email protected] Roll Engine from 5c760759feca to 621c88dc2d13 (2 revisions) (flutter/flutter#99792)
2022-03-09 [email protected] Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (flutter/flutter#99791)
2022-03-09 [email protected] remove unnecessary null check (flutter/flutter#99507)
2022-03-09 [email protected] Avoid calling `performLayout` when only the relayout boundary is different (flutter/flutter#99056)
2022-03-09 [email protected] Revert "Add the refresh rate fields to perf_test (#99710)" (flutter/flutter#99801)
2022-03-09 [email protected] Re-land removal of maxLengthEnforced deprecation (flutter/flutter#99787)
2022-03-09 [email protected] Add the refresh rate fields to perf_test (flutter/flutter#99710)
2022-03-09 [email protected] Remove tool crash git.io link shortener (flutter/flutter#99574)
2022-03-09 [email protected] 95533 min sdk error msgs enhancements (flutter/flutter#99550)
2022-03-08 [email protected] Remove deprecated OutlineButton (flutter/flutter#98546)
2022-03-08 [email protected] [flutter_tools] Fix Typo in tool error message (flutter/flutter#97793)
2022-03-08 [email protected] Handle hidden dot files in iOS framework bundles (flutter/flutter#99771)
2022-03-08 [email protected] Updated tokens to v0.88. (flutter/flutter#99568)
2022-03-08 [email protected] Revert "Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced" (flutter/flutter#99768)
2022-03-08 [email protected] Add Foldable support for modal routes (flutter/flutter#92909)
2022-03-08 [email protected] Roll Plugins from 675f91b to b906ea5 (4 revisions) (flutter/flutter#99765)
2022-03-08 [email protected] Roll Engine from 0fed94d050b1 to 5c760759feca (1 revision) (flutter/flutter#99751)
2022-03-08 [email protected] Fix: Date picker interactive sample not loading  (flutter/flutter#99401)
2022-03-08 [email protected] Check string size before Win32 MultiByte <-> WideChar conversions (flutter/flutter#99729)
2022-03-08 [email protected] Roll Engine from 9c3f73864029 to 0fed94d050b1 (6 revisions) (flutter/flutter#99728)
2022-03-08 [email protected] Adds a Listview tile select example (flutter/flutter#99165)
2022-03-08 [email protected] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced (flutter/flutter#98539)
2022-03-08 [email protected] Roll Engine from 9e1594bd741f to 9c3f73864029 (2 revisions) (flutter/flutter#99721)
2022-03-08 49699333+dependabot[bot]@users.noreply.github.com Bump debian from bullseye-20220125-slim to bullseye-20220228-slim in /dev/ci/docker_linux (flutter/flutter#99708)
...

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          67a0df4 Adds a Listview tile select example (flutter/flutter#99165)

e414012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity d: api docs d: examples f: scrolling