Skip to content

Reland clean up clipboard.#99363

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
chunhtai:reland-clipboard
Mar 4, 2022
Merged

Reland clean up clipboard.#99363
fluttergithubbot merged 2 commits intoflutter:masterfrom
chunhtai:reland-clipboard

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Mar 1, 2022

previous pr is reverted due to devtool failure

The soft transition code is in the second commit.

See #99360

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 1, 2022
@chunhtai chunhtai requested a review from justinmc March 1, 2022 23:20
justinmc
justinmc approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reland LGTM 👍

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit f7b9d1c into flutter:master Mar 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
0821181
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
2297fa7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
1fce727
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
a525336
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
83207a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
0927e46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
49165a5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
4ed4b21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
97fb4f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
61c1bff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
bd9b6c5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
832e753
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
8669bb0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
281fbed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
a6bd784
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
88d4c00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
c29fc23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
5edd21f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
f182506
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
20e5fcb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
f7b9d1c Reland clean up clipboard. (flutter/flutter#99363)
2992b71
This was referenced Mar 7, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @fluttergithubbot @justinmc