Fix: Date picker interactive sample not loading by maheshj01 · Pull Request #99401 · flutter/flutter

maheshj01 · 2022-03-02T14:50:45Z

Fixes interactive sample not loading

Fixes: #99338

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

HansMuller

LGTM

HansMuller

LGTM

fluttergithubbot · 2022-03-02T19:56:15Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

HansMuller · 2022-03-02T20:25:11Z

The Google Testing failure doesn't appear to have anything to with this PR:

google3:///[mobile/flutter/tools/icon_font/bin/icon_map_generator.dart:24](https://cs.corp.google.com/piper///depot/google3/mobile/flutter/tools/icon_font/bin/icon_map_generator.dart?l=24&ws=tap-presubmit-rerun-server/458933&snapshot=2):24: Error: Method not found: 'stringToTokenPairMap'.
  final tokenPairMap = stringToTokenPairMap(codepointsString);

I'll rerun the test however this PR will probably need to be sync'd with master (rebased).

maheshj01 · 2022-03-03T04:45:51Z

Unfortunately, rebase does not fix the Google testing failure

…ter#99401)

Roll Flutter from 38dbbb1 to 0dfb656 (135 revisions) flutter/flutter@38dbbb1...0dfb656 2022-03-10 [email protected] Roll Engine from bf2bf3a3fd2b to 6b1a24b1a108 (10 revisions) (flutter/flutter#99917) 2022-03-10 [email protected] Roll Plugins from eb6ad34 to 20e231b (8 revisions) (flutter/flutter#99913) 2022-03-10 [email protected] Roll Engine from 2c1816b39127 to bf2bf3a3fd2b (3 revisions) (flutter/flutter#99887) 2022-03-10 [email protected] Migrate NavigationRail to Material 3. (flutter/flutter#99171) 2022-03-10 [email protected] Remove expired ThemeData deprecations (flutter/flutter#98578) 2022-03-09 [email protected] Roll Engine from 09a11d137953 to 2c1816b39127 (3 revisions) (flutter/flutter#99878) 2022-03-09 [email protected] [ci.yaml] Remove unused benchmark property (flutter/flutter#99843) 2022-03-09 [email protected] [Material] Create an InkSparkle splash effect that matches the Material 3 ripple effect (flutter/flutter#99731) 2022-03-09 [email protected] Remove deprecated RenderEditable.onSelectionChanged (flutter/flutter#98582) 2022-03-09 [email protected] Marks Mac_ios post_backdrop_filter_perf_ios__timeline_summary to be flaky (flutter/flutter#99856) 2022-03-09 [email protected] Roll Engine from 6d7bcc9e577c to 09a11d137953 (3 revisions) (flutter/flutter#99870) 2022-03-09 [email protected] [tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates (flutter/flutter#94509) 2022-03-09 [email protected] First pass at using platform abstraction for plugins (flutter/flutter#92672) 2022-03-09 [email protected] Fix `ColorScheme.shadow` to default to black even for dark themes. (flutter/flutter#99722) 2022-03-09 [email protected] Roll Engine from a0963f14b67d to 6d7bcc9e577c (3 revisions) (flutter/flutter#99847) 2022-03-09 [email protected] Updated tokens to v0.90. (flutter/flutter#99782) 2022-03-09 [email protected] Marks Mac_ios backdrop_filter_perf_ios__timeline_summary to be unflaky (flutter/flutter#99836) 2022-03-09 [email protected] updateEditingValueWithDeltas snippet docs fix (flutter/flutter#99570) 2022-03-09 [email protected] Roll Engine from 9362061fbb79 to a0963f14b67d (1 revision) (flutter/flutter#99838) 2022-03-09 [email protected] Roll Plugins from b906ea5 to eb6ad34 (9 revisions) (flutter/flutter#99828) 2022-03-09 [email protected] Update visibility of methods for internal use (flutter/flutter#98124) 2022-03-09 [email protected] Roll Engine from 621c88dc2d13 to 9362061fbb79 (6 revisions) (flutter/flutter#99809) 2022-03-09 [email protected] Roll Engine from 5c760759feca to 621c88dc2d13 (2 revisions) (flutter/flutter#99792) 2022-03-09 [email protected] Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (flutter/flutter#99791) 2022-03-09 [email protected] remove unnecessary null check (flutter/flutter#99507) 2022-03-09 [email protected] Avoid calling `performLayout` when only the relayout boundary is different (flutter/flutter#99056) 2022-03-09 [email protected] Revert "Add the refresh rate fields to perf_test (#99710)" (flutter/flutter#99801) 2022-03-09 [email protected] Re-land removal of maxLengthEnforced deprecation (flutter/flutter#99787) 2022-03-09 [email protected] Add the refresh rate fields to perf_test (flutter/flutter#99710) 2022-03-09 [email protected] Remove tool crash git.io link shortener (flutter/flutter#99574) 2022-03-09 [email protected] 95533 min sdk error msgs enhancements (flutter/flutter#99550) 2022-03-08 [email protected] Remove deprecated OutlineButton (flutter/flutter#98546) 2022-03-08 [email protected] [flutter_tools] Fix Typo in tool error message (flutter/flutter#97793) 2022-03-08 [email protected] Handle hidden dot files in iOS framework bundles (flutter/flutter#99771) 2022-03-08 [email protected] Updated tokens to v0.88. (flutter/flutter#99568) 2022-03-08 [email protected] Revert "Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced" (flutter/flutter#99768) 2022-03-08 [email protected] Add Foldable support for modal routes (flutter/flutter#92909) 2022-03-08 [email protected] Roll Plugins from 675f91b to b906ea5 (4 revisions) (flutter/flutter#99765) 2022-03-08 [email protected] Roll Engine from 0fed94d050b1 to 5c760759feca (1 revision) (flutter/flutter#99751) 2022-03-08 [email protected] Fix: Date picker interactive sample not loading (flutter/flutter#99401) 2022-03-08 [email protected] Check string size before Win32 MultiByte <-> WideChar conversions (flutter/flutter#99729) 2022-03-08 [email protected] Roll Engine from 9c3f73864029 to 0fed94d050b1 (6 revisions) (flutter/flutter#99728) 2022-03-08 [email protected] Adds a Listview tile select example (flutter/flutter#99165) 2022-03-08 [email protected] Remove deprecated CupertinoTextField, TextField, TextFormField maxLengthEnforced (flutter/flutter#98539) 2022-03-08 [email protected] Roll Engine from 9e1594bd741f to 9c3f73864029 (2 revisions) (flutter/flutter#99721) 2022-03-08 49699333+dependabot[bot]@users.noreply.github.com Bump debian from bullseye-20220125-slim to bullseye-20220228-slim in /dev/ci/docker_linux (flutter/flutter#99708) ...

…ter#99401)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 2, 2022

HansMuller approved these changes Mar 2, 2022

View reviewed changes

HansMuller added the waiting for tree to go green label Mar 2, 2022

fluttergithubbot removed the waiting for tree to go green label Mar 2, 2022

fix interactive dartpad syntax

4ee9ce6

TahaTesser approved these changes Mar 8, 2022

View reviewed changes

TahaTesser added the waiting for tree to go green label Mar 8, 2022

fluttergithubbot merged commit 6e2d314 into flutter:master Mar 8, 2022

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 6e2d31459d08 (96 revisions) flutter/packages#1124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

cef6540

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 33ab8ebad7d1 (97 revisions) flutter/packages#1125

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

8ed762b

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 33ab8ebad7d1 (97 revisions) flutter/packages#1126

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

a4bdff9

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to ffe64c6336bf (98 revisions) flutter/packages#1127

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

0245b43

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to df7f05f7107b (99 revisions) flutter/packages#1128

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

4d4e723

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 06fb863ae5a4 (100 revisions) flutter/packages#1129

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

89e74b6

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 10805ca3fe6b to 06fb863ae5a4 (13 revisions) flutter/plugins#5018

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

03d0e2a

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to bb1b2fd07277 (101 revisions) flutter/packages#1130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

50abf32

…ter#99401)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

104bc8f

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 57aa49028db7 (132 revisions) flutter/packages#1168

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

be86780

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 57aa49028db7 (132 revisions) flutter/packages#1169

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

5132ee1

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 9c4976e4e7a1 (133 revisions) flutter/packages#1170

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

fe1ecd5

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 48172589e5ac (134 revisions) flutter/packages#1171

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

2e29dfe

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 0dfb656e28b9 (135 revisions) flutter/packages#1172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

601fe31

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 21320a1da5b0 (136 revisions) flutter/packages#1173

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

fc66102

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 7bd067ab2487 (137 revisions) flutter/packages#1174

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

2955eb0

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to dc928989f4d5 (138 revisions) flutter/packages#1175

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

a740ff3

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 2ed7cdf35a0e (139 revisions) flutter/packages#1176

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

e84f7b6

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 8235f5e3d3ed (140 revisions) flutter/packages#1178

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

bcf50a4

…ter#99401)

engine-flutter-autoroll mentioned this pull request Mar 10, 2022

Roll Flutter from 38dbbb17f8ce to 1880066dd3a0 (141 revisions) flutter/packages#1179

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

082593b

…ter#99401)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

520b984

…ter#99401)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

d979cd5

…ter#99401)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

18d4127

…ter#99401)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022

6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…

adc4d03

…ter#99401)

This was referenced Mar 1, 2024

showDateRangePicker interactive sample not loading #144474

Closed

Fix showDateRangePicker is missing dartpad tag and cleanup #144475

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Date picker interactive sample not loading #99401

Fix: Date picker interactive sample not loading #99401
fluttergithubbot merged 1 commit intoflutter:masterfrom
maheshj01:date_picker_sample_fix

maheshj01 commented Mar 2, 2022

Uh oh!

HansMuller left a comment

Uh oh!

HansMuller left a comment

Uh oh!

fluttergithubbot commented Mar 2, 2022

Uh oh!

HansMuller commented Mar 2, 2022

Uh oh!

maheshj01 commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

maheshj01 commented Mar 2, 2022

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Mar 2, 2022

Uh oh!

HansMuller commented Mar 2, 2022

Uh oh!

maheshj01 commented Mar 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants