Use BindingBase.platformDispatcher over BindingBase.window where possible#99443
Merged
fluttergithubbot merged 7 commits intoflutter:masterfrom Mar 4, 2022
Merged
Conversation
flutter-dashboard
bot
added
a: accessibility
goderbauer
changed the title
BindingBase.platformDispatcher over BindingBase.window where possible
gspencergoog
approved these changes
Mar 3, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
I like the factoring out of the test platform dispatcher.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 4, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2022
…` where possible (flutter/flutter#99443)
This was referenced Mar 7, 2022
|
Are there any examples of use？ |
Member
Author
Look at the files changed by this PR. They all show examples of how to use the platform dispatcher. |
Are there any PRs to support for macos now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for multi-window support and removes the bias towards a single window from some of the framework code. There's still more work to do...
This PR basically removes
SingletonFlutterWindowfrom the framework (with the exception of the still existingBindingBase.windowandTestWindowfrom flutter_test - but all code now treats them as being regularFlutterViews and doesn't rely on any of the additional backwards-compatibility functionality thatSingletonFlutterWindowprovides overFlutterView).Part of #60131 to work towards #30701.