Use PlatformDispatcher.instance over window where possible#99496
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Mar 3, 2022
Merged
Use PlatformDispatcher.instance over window where possible#99496fluttergithubbot merged 1 commit intoflutter:masterfrom
PlatformDispatcher.instance over window where possible#99496fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: accessibility
goderbauer
changed the title
PlatformDispatcher.instance over window where possible
gspencergoog
approved these changes
Mar 3, 2022
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
It's good to see this!
Are you planning to deprecate window too?
Member
Author
Long term that's the plan. Need to have a new way to get your current window first, though (e.g. via an InheritedWidget or something). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2022
This was referenced Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #99443, but focused on direct usage of dart:ui's
windowglobal and moves those usages toPlatformDispatcher.instance.Where appropriate, the PR also moves away from using the globals exposed by
dart:uidirectly and instead accesses the window/platformDispatcher via the Binding as recommended in the docs [1] and [2].Part of #60131 to work towards #30701.
[1] https://master-api.flutter.dev/flutter/dart-ui/window.html
[2] https://master-api.flutter.dev/flutter/dart-ui/PlatformDispatcher/instance.html