Skip to content

CupertinoContextMenu/ContextMenuAction: Add clickable cursor for web#99519

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:context_menu_web_cursor
Apr 12, 2022
Merged

CupertinoContextMenu/ContextMenuAction: Add clickable cursor for web#99519
fluttergithubbot merged 4 commits intoflutter:masterfrom
NevercodeHQ:context_menu_web_cursor

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Mar 3, 2022 •
edited
Loading

part of #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoContextMenu

Launching integration_test/cupertino/cupertino_context_menu.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_context_menu.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:56350/DTH7jaimvhA=/ws
Debug service listening on ws://127.0.0.1:56350/DTH7jaimvhA=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:56350/DTH7jaimvhA=/ws
00:00 +0: Hovering over Cupertino context menu updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

CupertinoContextMenuAction

Launching integration_test/cupertino/cupertino_context_menu.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_context_menu.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:57326/SQxGCQ7HeeY=/ws
Debug service listening on ws://127.0.0.1:57326/SQxGCQ7HeeY=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:57326/SQxGCQ7HeeY=/ws
00:00 +0: Hovering over Cupertino context menu action updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 3, 2022
@TahaTesser TahaTesser mentioned this pull request Mar 4, 2022
Closed
@TahaTesser TahaTesser changed the title CupertinoContextMenu: Add clickable cursor for web CupertinoContextMenu/ContextMenuAction: Add clickable cursor for web Mar 4, 2022
@TahaTesser
Copy link
Contributor Author

TahaTesser commented Apr 7, 2022

cc: @Renzo-Olivares

Renzo-Olivares
Renzo-Olivares approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 0a178f8 into flutter:master Apr 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
0a178f8 CupertinoContextMenu/ContextMenuAction: Add clickable cur…
8c1ec51 
…sor for web (flutter/flutter#99519)
@TahaTesser TahaTesser deleted the context_menu_web_cursor branch April 12, 2022 17:52
chunhtai added a commit to chunhtai/flutter that referenced this pull request Apr 12, 2022
@chunhtai
Revert "CupertinoContextMenu/ContextMenuAction: Add clickable cur…
6eb52ca 
…sor for web (flutter#99519)"

This reverts commit 0a178f8.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
0a178f8 CupertinoContextMenu/ContextMenuAction: Add clickable cur…
196e14f 
…sor for web (flutter/flutter#99519)
@iskakaushik iskakaushik mentioned this pull request Apr 13, 2022
Closed
iskakaushik added a commit to iskakaushik/flutter that referenced this pull request Apr 13, 2022
@iskakaushik
Revert "CupertinoContextMenu/ContextMenuAction: Add clickable cur…
9699971 
…sor for web (flutter#99519)"

See: flutter#99519

This reverts commit 0a178f8.
@iskakaushik iskakaushik mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @Renzo-Olivares @fluttergithubbot