Skip to content

fix type error in service_worker_test.dart#99524

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
chris-forks:fix-type-in-service-worker-test
Mar 4, 2022
Merged

fix type error in service_worker_test.dart#99524
fluttergithubbot merged 2 commits intoflutter:masterfrom
chris-forks:fix-type-in-service-worker-test

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 4, 2022

make map literal match an internal Map<dynamic, dynamic> in package:match

Fixes #99522

Note, this map literal needs to match the type of https://github.com/dart-lang/matcher/blob/0.12.11/lib/src/equals_matcher.dart#L261

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 4, 2022
jmagman
jmagman approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth filing an issue on https://github.com/dart-lang/matcher it shouldn't crash like that.

@mdebbar
Copy link
Contributor

mdebbar commented Mar 4, 2022

Thanks for fixing this, @christopherfujino!

@christopherfujino christopherfujino mentioned this pull request Mar 4, 2022
Merged
8 tasks
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 09c7eb1 into flutter:master Mar 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
a106572 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
9592cf6 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
afd5e82 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
f6a3101 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
b43e189 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
d8670d2 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
70295f4 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
9ac0abf 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
85a38e3 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
fea982e 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
5171a65 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
f32c1fc 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
8c83617 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
3d1297f 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
f3a1778 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
fdcb4b6 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
b16c3b2 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
8a58328 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
03e6d66 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
f296a8d 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
30132ce 
…9524)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
09c7eb1 fix type error in service_worker_test.dart (flutter/flutter#9…
9cbd2a2 
…9524)
This was referenced Mar 8, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

service_worker_test.dart has a type error

4 participants

@christopherfujino @mdebbar @fluttergithubbot @jmagman