CupertinoSlider: Add clickable cursor for web#99557
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jun 8, 2022
Merged
CupertinoSlider: Add clickable cursor for web#99557fluttergithubbot merged 1 commit intoflutter:masterfrom
CupertinoSlider: Add clickable cursor for web#99557fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
CupertinoSlider: Add clickable cursor for web
Contributor
Author
|
cc: @Renzo-Olivares |
Renzo-Olivares
approved these changes
Jun 8, 2022
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Tried it out, this LGTM. I was curious why you did this one with MouseTrackerAnnotation instead of MouseRegion like the other cupertino widgets but I see why now. That would make the entire slider visually clickable and not just the handle. Sorry for the delay, this needs a rebase.
80bbe3b to
7e13d79
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 8, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #86174
Complete details #86174 (comment)
Integration test for web results:
CupertinoSlider
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.