Add Windows performance benchmark#99564
Conversation
flutter-dashboard
bot
added
f: scrolling
.ci.yaml
Outdated
| - bin/** | ||
| - .ci.yaml | ||
|
|
||
| - name: Windows home_scroll_perf__timeline_summary |
There was a problem hiding this comment.
Builder name follows the format Platform + task name: Windows home_scroll_perf__timeline_summary => Windows windows_home_scroll_perf__timeline_summary
There was a problem hiding this comment.
Not sure if this will fail the led run, will try based on this PR to see how it goes.
|
Updated the tool so it now supports non-fatal --screenshot on unsupported devices |
| Cache.enableLocking(); | ||
| }); | ||
|
|
||
| testUsingContext('warns if screenshot is not supported but continues test', () async { |
There was a problem hiding this comment.
FYI @christopherfujino , this is a lot easier than tracking whether each device supports screenshotting in the devicelab codebase
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
We also need an entry in ownership file: https://github.com/flutter/flutter/blob/master/TESTOWNERS to bypass the owner check.
.ci.yaml
Outdated
|
|
||
| - name: Windows windows_home_scroll_perf__timeline_summary | ||
| recipe: devicelab/devicelab_drone | ||
| presubmit: true |
There was a problem hiding this comment.
The current workflow is using bringup: true first.
We don't need presubmit: true here: 1) ci yaml roller use default value true for presubmit 2) With this set, it will cause the presubmit hang on this test as there is not available builder config yet.
flutter-dashboard
bot
added
the
tool
TESTOWNERS
Outdated
| ## Windows Devicelab tests | ||
| /dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine | ||
|
|
There was a problem hiding this comment.
Nit: this can be added in section: ## Host only DeviceLab tests
| Cache.enableLocking(); | ||
| }); | ||
|
|
||
| testUsingContext('warns if screenshot is not supported but continues test', () async { |
5 participants
We need at least one benchmark to test if flutter/engine#31830 improves rendering performance.
This adds a single windows host benchmark, with a small change to the tool to simplify devicelab integration