Add logging when first frame is not rendering by jmagman · Pull Request #99566 · flutter/flutter

jmagman · 2022-03-04T20:00:54Z

Help debug #98419

[+181880 ms] First frame is taking longer than expected...
[+2804 ms] View ID: _flutterView/0x121815820
[  +27 ms] Isolate isolates/2451146379095359 state:
[   +6 ms] {"type":"Isolate","id":"isolates/2451146379095359","number":"2451146379095359","name":"main","isSystemIsolate":false,"isolateFlags":[{"name":"copy_parent_code","valueAsString":"false"},{"name":"is_system_isolate","valueAsString":"false"}],"startTime":1646423553553,"runnable":true,"livePorts":0,"pauseOnExit":false,"pauseEvent":{"type":"Event","kind":"Resume","timestamp":1646423553614,"isolate":{"type":"@Isolate","id":"isolates/2451146379095359","number":"2451146379095359","name":"main","isSystemIsolate":false}},"breakpoints":[],"exceptionPauseMode":"None","rootLib":{"type":"@Library","id":"libraries/@564330433","fixedId":true,"name":"","uri":"package:flutter_view/main.dart"},"extensionRPCs":["ext.dart.io.getHttpEnableTimelineLogging","ext.dart.io.setHttpEnableTimelineLogging","ext.dart.io.httpEnableTimelineLogging","ext.dart.io.getSocketProfile","ext.dart.io.startSocketProfiling","ext.dart.io.pauseSocketProfiling","ext.dart.io.socketProfilingEnabled","ext.dart.io.clearSocketProfile","ext.dart.io.getVersion","ext.dart.io.getHttpProfile","ext.dart.io.getHttpProfileRequest","ext.dart.io.clearHttpProfile","ext.flutter.exit","ext.flutter.connectedVmServiceUri","ext.flutter.activeDevToolsServerAddress","ext.flutter.timeDilation","ext.flutter.debugDumpRenderTree","ext.flutter.debugDumpSemanticsTreeInTraversalOrder","ext.flutter.debugDumpSemanticsTreeInInverseHitTestOrder","ext.flutter.profileRenderObjectPaints","ext.flutter.profileRenderObjectLayouts","ext.flutter.debugDumpApp","ext.flutter.showPerformanceOverlay","ext.flutter.didSendFirstFrameEvent","ext.flutter.didSendFirstFrameRasterizedEvent","ext.flutter.fastReassemble","ext.flutter.profileWidgetBuilds"]}
[        ] Received VM events:
[        ] Flutter.ServiceExtensionStateChanged: [ExtensionData {extension: ext.flutter.activeDevToolsServerAddress, value: http://127.0.0.1:9100}]
           Flutter.ServiceExtensionStateChanged: [ExtensionData {extension: ext.flutter.connectedVmServiceUri, value: http://127.0.0.1:61703/bCbbp06lomA=/}]

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-03-04T20:49:01Z

packages/flutter_tools/lib/src/tracing.dart

+                _logger.printTrace('No isolate ID associated with the view.');
+                continue;
+              }
+              final vm_service.Isolate? isolate = await vmService.getIsolateOrNull(isolateId);


We have the isolate here, is there anything else helpful to add?

How about getStack() https://github.com/dart-lang/sdk/blob/main/runtime/vm/service/service.md#getstack ? Not sure what the Dart API for that is, though.

That doesn't work in profile mode.

RPCError: getStack: (100) Feature is disabled Debugger is disabled in AOT mode. #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:1734:45) #1 VmService._call (package:vm_service/src/vm_service.dart:2245:21) #2 VmService.getStack (package:vm_service/src/vm_service.dart:2021:61) #3 Tracing.stopTracingAndDownloadTimeline.<anonymous closure> (package:flutter_tools/src/tracing.dart:85:70)

zanderso · 2022-03-04T20:54:02Z

packages/flutter_tools/lib/src/tracing.dart

+                _logger.printTrace('No isolate ID associated with the view.');
+                continue;
+              }
+              final vm_service.Isolate? isolate = await vmService.getIsolateOrNull(isolateId);


How about getStack() https://github.com/dart-lang/sdk/blob/main/runtime/vm/service/service.md#getstack ? Not sure what the Dart API for that is, though.

fluttergithubbot · 2022-03-05T00:11:15Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux web_long_running_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r#99566)

jmagman added the team: flakes label Mar 4, 2022

jmagman self-assigned this Mar 4, 2022

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2022

Add logging when first frame is not rendering

7fa48ed

jmagman requested a review from zanderso March 4, 2022 20:48

jmagman force-pushed the tracing-isolate branch from 5674706 to 7fa48ed Compare March 4, 2022 20:48

jmagman commented Mar 4, 2022

View reviewed changes

zanderso approved these changes Mar 4, 2022

View reviewed changes

jmagman added 3 commits March 4, 2022 13:03

stack

2631c56

Move stack

51e895b

remove stack

23e0a16

jmagman added the waiting for tree to go green label Mar 4, 2022

fluttergithubbot removed the waiting for tree to go green label Mar 5, 2022

jmagman added the waiting for tree to go green label Mar 5, 2022

fluttergithubbot merged commit 7596a3d into flutter:master Mar 5, 2022

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to 7596a3daf64e (59 revisions) flutter/packages#1065

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

429d7b6

…r#99566)

jmagman deleted the tracing-isolate branch March 5, 2022 01:34

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to 2641f79145f1 (60 revisions) flutter/packages#1066

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

94327e1

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to ca9ecbc02d9a (61 revisions) flutter/packages#1067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

c836313

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to ca9ecbc02d9a (61 revisions) flutter/packages#1068

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

6e1e7bd

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to ea0b771d9811 (62 revisions) flutter/packages#1069

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

9189e6b

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to ea0b771d9811 (62 revisions) flutter/packages#1070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

edb0024

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 5, 2022

Roll Flutter from 38dbbb17f8ce to ea0b771d9811 (62 revisions) flutter/packages#1071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

8e58a97

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 23ea5120d4f2 (89 revisions) flutter/packages#1114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

7929285

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c188930554b7 (90 revisions) flutter/packages#1115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

3fc7af4

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c15ec6a13e5d (91 revisions) flutter/packages#1116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

ffd32a8

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 5ae4885e5edd (92 revisions) flutter/packages#1117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

fb991e3

…r#99566)

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022

Add logging when first frame is not rendering (flutter#99566)

5b98288

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 67a0df41cd7f (93 revisions) flutter/packages#1118

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

332e1ef

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to dfd8bde04499 (94 revisions) flutter/packages#1119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

1671d54

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to b5d3c43280bb (95 revisions) flutter/packages#1120

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

3333153

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to b5d3c43280bb (95 revisions) flutter/packages#1121

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

cafbda4

…r#99566)

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to b5d3c43280bb (95 revisions) flutter/packages#1123

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

7596a3d Add logging when first frame is not rendering (flutter/flutte…

30aa3aa

…r#99566)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logging when first frame is not rendering#99566

Add logging when first frame is not rendering#99566
fluttergithubbot merged 4 commits intoflutter:masterfrom
jmagman:tracing-isolate

jmagman commented Mar 4, 2022 •

edited

Loading

Uh oh!

jmagman Mar 4, 2022

Uh oh!

zanderso Mar 4, 2022

Uh oh!

jmagman Mar 4, 2022 •

edited

Loading

Uh oh!

zanderso Mar 4, 2022

Uh oh!

fluttergithubbot commented Mar 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmagman commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

zanderso Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zanderso Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Mar 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Mar 4, 2022 •

edited

Loading

jmagman Mar 4, 2022 •

edited

Loading