Skip to content

Remove tool crash git.io link shortener#99574

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:remove-shortener
Mar 9, 2022
Merged

Remove tool crash git.io link shortener#99574
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:remove-shortener

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 4, 2022

git.io link shortener is dead, service responding 422. GitHub has removed the service as of January 2022.

Remove the code that posts a request to have the link shortened.

Fixes #53140
See also #99572

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2022
@jmagman jmagman self-assigned this Mar 4, 2022
@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Mar 4, 2022
@jmagman jmagman force-pushed the remove-shortener branch from 4ed7b53 to e3be2bf Compare March 4, 2022 23:44
@jmagman jmagman force-pushed the remove-shortener branch from e3be2bf to ef5d21c Compare March 4, 2022 23:44
jmagman
jmagman commented Mar 4, 2022
View reviewed changes
packages/flutter_tools/test/src/fake_http_client.dart
///
/// This should only be used when the http client cannot be set directly, such as
/// when testing `package:http` code.
Future<void> overrideHttpClients(Future<void> Function() callback, FakeHttpClient httpClient) async {
Copy link
Member Author

@jmagman jmagman Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found dead code.

Copy link
Contributor

@christopherfujino christopherfujino Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

christopherfujino
christopherfujino approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP git.io

Jasguerrero
Jasguerrero approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit dd97133 into flutter:master Mar 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
@jmagman jmagman deleted the remove-shortener branch March 9, 2022 01:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
d4068e0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
c57a3d6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
20090cb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
47c016a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
932ab5b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
3b26a06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
87063df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
547e1a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
f9b7381
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
bbb2342
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
ca3d087
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
c11e854
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
f84f1e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
edfee0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
fe672f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
70b5295
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
167667b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
9d25f49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
bf89314
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
793a76e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
be041ff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)
b5c4751
This was referenced Mar 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHubTemplateCreator potentially leaks information to GitHub

4 participants

@jmagman @christopherfujino @Jasguerrero @fluttergithubbot