Remove package:typed_data from package:flutter dependencies by jonahwilliams · Pull Request #99604 · flutter/flutter

jonahwilliams · 2022-03-05T17:32:06Z

Replace the usaged of the Uint8Buffer from package:typed_data with a List. This actually improves performance on wembly, using the following benchmark:

import 'package:flutter/services.dart';

ByteData? result;

void main() {
  for (var x = 0; x < 10; x++) {
    var codec = StandardMessageCodec();
    var sw = Stopwatch()..start();
    for (var i = 0; i < 100; i++) {
      result = codec.encodeMessage({
        for (var i = 0; i < 200; i++)
          i: [for (var j = 0; j < 23; j++) j]
      });
    }
    print(sw.elapsedMilliseconds);
    print(result);
  }
}

ToT:

An Observatory debugger and profiler on wembley is available at: http://127.0.0.1:61792/wKRO2rVZZf4=/
I/flutter ( 4652): 488
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 451
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 449
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 449
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 447
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 448
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 449
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 449
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 450
I/flutter ( 4652): TypedDataView(cid: 148)
I/flutter ( 4652): 448
I/flutter ( 4652): TypedDataView(cid: 148)

With Change

An Observatory debugger and profiler on wembley is available at: http://127.0.0.1:61886/wBKsj-QFjxY=/
I/flutter ( 4807): 456
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 372
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 363
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 368
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 364
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 362
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 363
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 363
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 363
I/flutter ( 4807): TypedDataView(cid: 148)
I/flutter ( 4807): 364
I/flutter ( 4807): TypedDataView(cid: 148)

jonahwilliams · 2022-03-05T17:32:28Z

packages/flutter/lib/src/foundation/serialization.dart

-      _isDone = false,
-      _eightBytes = ByteData(8) {
-    _eightBytesAsList = _eightBytes.buffer.asUint8List();
+  factory WriteBuffer() {


Allows avoiding a late for _eightBytesAsList

jonahwilliams · 2022-03-05T17:33:02Z

packages/flutter/pubspec.yaml

  collection: 1.15.0
  material_color_utilities: 0.1.4
  meta: 1.7.0
-  typed_data: 1.3.0


Need to run update-packages, delaying until approved due to churn

dnfield

Lgtm as long as update packages is happy

I wonder how much we're saving by avoiding the late field vs the list.

dnfield · 2022-03-05T21:53:19Z

Do we have some list of forbidden packages too? If so we should add this one.

jonahwilliams · 2022-03-06T03:09:44Z

Probably not much but IMO late is best avoided if its easy to

dnfield · 2022-03-06T03:33:04Z

Late requires extra runtime checks on every access

jonahwilliams · 2022-03-06T04:05:11Z

Yup, and I'm sure it makes some difference. Though I prefer to avoid it not for performance reasons but because it more or less disables the static analysis you get for correct initialization.

jonahwilliams · 2022-03-06T18:12:37Z

Turns out package:typed_data is still used elsewhere. Will follow up to see if it is easy to remove

jonahwilliams · 2022-03-06T18:26:12Z

Requires a g3fix to update BUILD file

fluttergithubbot · 2022-03-06T18:31:12Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2022-03-06T18:41:14Z

Looks like flutter_goldens_client uses package:crypto for md5 encoding which pulls in package:typed_data

goderbauer

LGTM

goderbauer · 2022-03-07T17:40:40Z

dev/integration_tests/flutter_gallery/linux/flutter/generated_plugins.cmake

  url_launcher_linux
 )

+list(APPEND FLUTTER_FFI_PLUGIN_LIST


Is the change to this file related to this PR?

This probably comes from running pub get aftr the FFI plugin change.

This gets auto updated whenever I run it, and it looks like its not gitignored....

Should be safe to check in :D

…lutter/flutter#99604)

remove package:typed_data from dependencies

7f3fad7

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 5, 2022

jonahwilliams commented Mar 5, 2022

View reviewed changes

jonahwilliams requested review from dnfield and goderbauer March 5, 2022 17:33

dnfield approved these changes Mar 5, 2022

View reviewed changes

jonahwilliams and others added 2 commits March 6, 2022 09:19

update-packages

89fc5b7

Update allowlist.dart

7ac4f3b

jonahwilliams added the waiting for tree to go green label Mar 6, 2022

jonahwilliams changed the title ~~Remove package:typed_data from dependencies~~ Remove package:typed_data from package:flutter dependencies Mar 6, 2022

fluttergithubbot removed the waiting for tree to go green label Mar 6, 2022

update test private

b858d1f

goderbauer approved these changes Mar 7, 2022

View reviewed changes

jonahwilliams added the waiting for tree to go green label Mar 7, 2022

fluttergithubbot merged commit 67f25ca into flutter:master Mar 7, 2022

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 67f25caf727c (79 revisions) flutter/packages#1104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

8375bf6

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to b02150781f04 (80 revisions) flutter/packages#1105

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

3d4514e

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to fbbf3ec4712b (81 revisions) flutter/packages#1106

Closed

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 39f31f0e3035 (114 revisions) flutter/packages#1146

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

e790b0a

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 39f31f0e3035 (114 revisions) flutter/packages#1148

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

55e846c

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 39f31f0e3035 (114 revisions) flutter/packages#1149

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

8a67f11

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to b4abc233ee18 (115 revisions) flutter/packages#1150

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

572608b

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 9cfaabaed09e (116 revisions) flutter/packages#1151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

f62088e

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to cff36b946ea8 (117 revisions) flutter/packages#1153

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

925ea4a

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 035eeb532e29 (118 revisions) flutter/packages#1154

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

b082931

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 400de160ec37 (119 revisions) flutter/packages#1155

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

8e98fda

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to e8c7a88914e5 (120 revisions) flutter/packages#1156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

2cb5770

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 010910f71cd7 (121 revisions) flutter/packages#1157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

b183259

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to e8af40f06b24 (122 revisions) flutter/packages#1158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

89f6232

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 0aab22807c2b (123 revisions) flutter/packages#1159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

c372d30

…lutter/flutter#99604)

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 291b28641740 (124 revisions) flutter/packages#1160

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

ef700e3

…lutter/flutter#99604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

c1b6fa3

…lutter/flutter#99604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

ba019df

…lutter/flutter#99604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

0bc34d8

…lutter/flutter#99604)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

67f25ca Remove package:typed_data from package:flutter dependencies (f…

f626048

…lutter/flutter#99604)

Conversation

jonahwilliams commented Mar 5, 2022

Uh oh!

jonahwilliams Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

dnfield commented Mar 5, 2022

Uh oh!

jonahwilliams commented Mar 6, 2022

Uh oh!

dnfield commented Mar 6, 2022

Uh oh!

jonahwilliams commented Mar 6, 2022

Uh oh!

jonahwilliams commented Mar 6, 2022

Uh oh!

jonahwilliams commented Mar 6, 2022

Uh oh!

fluttergithubbot commented Mar 6, 2022

Uh oh!

jonahwilliams commented Mar 6, 2022

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer Mar 7, 2022

Choose a reason for hiding this comment

Uh oh!

dnfield Mar 7, 2022

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Mar 7, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants