Skip to content

docs: Add more potential use case for Bottom Navigation Bar#99644

Merged
auto-submit[bot] merged 6 commits intoflutter:masterfrom
amanv8060:33810
Jun 23, 2022
Merged

docs: Add more potential use case for Bottom Navigation Bar#99644
auto-submit[bot] merged 6 commits intoflutter:masterfrom
amanv8060:33810

Conversation

@amanv8060
Copy link
Contributor

@amanv8060 amanv8060 commented Mar 6, 2022 •
edited
Loading

Adds the dartpad example for the use case mentioned in the issue

Fixes #33810

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 6, 2022
@HansMuller HansMuller self-requested a review March 18, 2022 23:09
@amanv8060
Copy link
Contributor Author

amanv8060 commented May 2, 2022

@HansMuller does this pr need additional changes?

guidezpl
guidezpl requested changes Jun 3, 2022
View reviewed changes
@HansMuller
Copy link
Contributor

HansMuller commented Jun 3, 2022

The new examples system requires a tests for each example. They can be simple basic functionality unit tests. See for example examples/api/test/material/appbar/app_bar.0_test.dart

@amanv8060 amanv8060 requested a review from guidezpl June 11, 2022 15:27
guidezpl
guidezpl requested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I like the example for scrolling to top, but using bottom nav to change state is a bit of an anti-pattern.

It would be more useful to showcase an example like "having a unique item that doesn't update the selectedIndex (ie. a button that opens a dropdown or modal instead of updating the displayed Scaffold.body)"

examples/api/lib/material/bottom_navigation_bar/bottom_navigation_bar.2.dart
onTap: (int index) {
switch (index) {
case 0:
_homeController.animateTo(
Copy link
Member

@guidezpl guidezpl Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only scroll if the selected tab is index

Copy link
Contributor Author

@amanv8060 amanv8060 Jun 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

Copy link
Member

@guidezpl guidezpl Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing _selectedIndex == 0, perhaps you need to push?

Copy link
Contributor Author

@amanv8060 amanv8060 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now.

@amanv8060 amanv8060 requested a review from guidezpl June 19, 2022 12:18
@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

1 similar comment
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

2 similar comments
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 23, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

17 similar comments
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

jonahwilliams
jonahwilliams approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@auto-submit auto-submit bot merged commit 3022db2 into flutter:master Jun 23, 2022
@amanv8060 amanv8060 deleted the 33810 branch June 23, 2022 17:19
This was referenced Jun 24, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…
443fe02 
…lutter/flutter#99644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2022
@engine-flutter-autoroll
3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…
728e712 
…lutter/flutter#99644)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@amanv8060 @camsim99
docs: Add more potential use case for Bottom Navigation Bar (flutter#…
fc7ed08 
…99644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…
addb55c 
…lutter/flutter#99644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…
6f034f8 
…lutter/flutter#99644)
@Piinks Piinks mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Documentation] Additional BottomNavigationBar use cases through samples

4 participants

@amanv8060 @HansMuller @guidezpl @jonahwilliams