Skip to content

Add the refresh rate fields to perf_test#99710

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
cyanglaz:framerate_benchmark
Mar 9, 2022
Merged

Add the refresh rate fields to perf_test#99710
fluttergithubbot merged 3 commits intoflutter:masterfrom
cyanglaz:framerate_benchmark

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 7, 2022

This PR adds the refresh rate benchmark fields to perf_test. This PR also adds 80Hz as a new valid fresh rate, this is because [iOS promotion display supports 80Hz] (https://developer.apple.com/documentation/quartzcore/optimizing_promotion_refresh_rates_for_iphone_13_pro_and_ipad_pro?language=objc)

Fixes #99516

If after landing this we can verity that these values are tracked in the benchmark, we can create a new PR to track all the lower refresh rates that supported by promotion display before closing #95700

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 7, 2022
@cyanglaz cyanglaz requested a review from dnfield March 7, 2022 21:42
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Mar 7, 2022

@dnfield Tested locally that the output contains the new fields. Prob also need your help with how to grab those values from LUCI after landing this.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Mar 7, 2022

cc @iskakaushik

@fluttergithubbot fluttergithubbot merged commit a7c8599 into flutter:master Mar 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
afdbea9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
1aa7746
@bdero bdero mentioned this pull request Mar 9, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
8bb61ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
abcadc0
zanderso added a commit that referenced this pull request Mar 9, 2022
@zanderso
Revert "Add the refresh rate fields to perf_test (#99710)"
5877692 
This reverts commit a7c8599.
@zanderso zanderso mentioned this pull request Mar 9, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
6ae6536
zanderso added a commit that referenced this pull request Mar 9, 2022
@zanderso
Revert "Add the refresh rate fields to perf_test (#99710)" (#99801)
5f76ac3 
This reverts commit a7c8599.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
2da29c6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
e022fb3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
50ff7da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
7e0691e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
f408f64
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
fb1887f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
5729843
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
20fcd04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
7b41d90
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
065f7f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
c8139f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
e9ad215
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
087571b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
3382a80
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
b73334a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
e557040
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
a7c8599 Add the refresh rate fields to perf_test (flutter/flutter#99710)
f9f2865
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to make the fields in TimelineSummary being collected by skia

3 participants

@cyanglaz @dnfield @fluttergithubbot