Skip to content

Handle hidden dot files in iOS framework bundles#99771

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
jmagman:dot-file
Mar 8, 2022
Merged

Handle hidden dot files in iOS framework bundles#99771
fluttergithubbot merged 3 commits intoflutter:masterfrom
jmagman:dot-file

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 8, 2022

Fixes #99229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 8, 2022
@jmagman jmagman self-assigned this Mar 8, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 8, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Christopher Fujino <[email protected]>
@fluttergithubbot fluttergithubbot merged commit 47a5b18 into flutter:master Mar 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@jmagman jmagman deleted the dot-file branch March 9, 2022 00:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@casyalex
Copy link

casyalex commented Aug 24, 2022

HI, When wil this fix be released? I checked it is not included at 3.0.5 tag. But it has been two months since it was merged...

@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2022

@casyalex It became available in 2.13.0-0.1.pre, so the fix is also in 3.0.5. Just confirmed:

$ git co 3.0.5
HEAD is now at f1875d570e [flutter_releases] Flutter stable 3.0.5 Framework Cherrypicks (#107565)
$ grep -riI "Hidden file" packages/flutter_tools/bin/podhelper.rb
packages/flutter_tools/bin/podhelper.rb:      continue if xcframework_file.start_with?(".") # Hidden file, possibly on external disk.

If you're still seeing a problem, please file a new issue and completely fill out the template. Thanks!

@casyalex
Copy link

casyalex commented Aug 24, 2022

continue if xcframework_file.start_with?(".") # Hidden file, possibly on external disk.
#

@jmagman Might got override or some how, please check above link?

I alos check my local 3.0.5 source code, the continue still there..

here is the whole file https://github.com/flutter/flutter/blob/3.0.5/packages/flutter_tools/bin/podhelper.rb

===============================

Sorry. I found out I reply the wrong MR, it should reference this. And this mr should be the cause of this issue.
#104296

And it still not included in stable channel...

@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2022

@casyalex #104296 is in 3.1.0-9.0.pre. Please see https://github.com/flutter/flutter/wiki/Where's-my-Commit%3F#finding-the-versions-that-contain-framework-commit-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

4 participants