Skip to content

Re-land removal of maxLengthEnforced deprecation#99787

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
Piinks:maxLength2
Mar 9, 2022
Merged

Re-land removal of maxLengthEnforced deprecation#99787
fluttergithubbot merged 5 commits intoflutter:masterfrom
Piinks:maxLength2

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 8, 2022

Original PR: #98539
This change was reverted in order to migrate another customer. It should be good to land now.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 8, 2022
justinmc
justinmc approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reland LGTM 👍

@fluttergithubbot fluttergithubbot merged commit 3172065 into flutter:master Mar 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
e29dd07 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
4432a05 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
f33b823 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
e5a517e 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
902d86b 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
5508fd5 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
8fba35f 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
845d557 
…tter#99787)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
3c7df74 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
894fafd 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
01f47c0 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
6d7d24b 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
f78779d 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
778e49d 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
10e7746 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
d3b977a 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
f01e6c1 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
425c95f 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
ea89e08 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
0c42cb1 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
8ee4f04 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
8a08931 
…tter#99787)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
5a3a90f 
…tter#99787)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3172065 Re-land removal of maxLengthEnforced deprecation (flutter/flu…
f45e3fd 
…tter#99787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @justinmc @fluttergithubbot