Skip to content

Revert "Add the refresh rate fields to perf_test"#99801

Merged
zanderso merged 1 commit intomasterfrom
revert-99710-framerate_benchmark
Mar 9, 2022
Merged

Revert "Add the refresh rate fields to perf_test"#99801
zanderso merged 1 commit intomasterfrom
revert-99710-framerate_benchmark

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 9, 2022

@zanderso zanderso requested a review from cyanglaz March 9, 2022 05:15
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 9, 2022
@zanderso zanderso requested review from dnfield and flar March 9, 2022 05:15
@bdero
Copy link
Contributor

bdero commented Mar 9, 2022

There's a bug for this here: #99796

@zanderso
Copy link
Member Author

zanderso commented Mar 9, 2022

We should revert to reopen the tree and then investigate after

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 9, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@bdero
Copy link
Contributor

bdero commented Mar 9, 2022

Ah right, I didn't notice it was blocking up the flutter repo

dnfield
dnfield approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 5f76ac3 into master Mar 9, 2022
@zanderso zanderso deleted the revert-99710-framerate_benchmark branch March 9, 2022 07:04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
7ace857 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
00a8f24 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
819670b 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
fc5dc77 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
c0a0ae8 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
e413f92 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
c2b93f5 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
ec9f1c9 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
d4f581c 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
7a0448b 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
b0f6dc8 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
6824937 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
f4f2fb1 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
e57148f 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
a0a0db0 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
229df6f 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
7d32277 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
465bc8e 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
02f1c9a 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
f2e6491 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
5f76ac3 Revert "Add the refresh rate fields to perf_test (#99710)" (f…
c19b55d 
…lutter/flutter#99801)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdero bdero bdero approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@flar flar Awaiting requested review from flar

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @bdero @fluttergithubbot @dnfield