Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

[Benchmarks] Add performance transitions test for crane only#216

Merged
guidezpl merged 2 commits intomasterfrom
crane-transitions-perf-test
Jul 17, 2020
Merged

[Benchmarks] Add performance transitions test for crane only#216
guidezpl merged 2 commits intomasterfrom
crane-transitions-perf-test

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Jul 17, 2020

Adds a test to perform the transitions test for Crane only.

To run the transitions_perf test for all demos:
flutter drive --profile --trace-startup -t test_driver/transitions_perf.dart -d <device>
To run the transitions_perf test for just Crane:
flutter drive --profile --trace-startup -t test_driver/transitions_perf.dart -d <device> --dart-define=onlyCrane=true

Since --tags isn't yet supported for flutter driver tests and skip isn't designed for runtime determination, this is the simplest way to conditionally run a driver test from the command line.

Closes #214

@guidezpl guidezpl requested a review from liyuqian July 17, 2020 14:36

final summary = TimelineSummary.summarize(timeline);
await summary.writeSummaryToFile('transitions-crane', pretty: true);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all demos test has a timeout, should this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not, I'll add one

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for quickly adding this test! I'll add it to devicelab for iOS/Android shortly. CC @yjbanov @ferhatb to see if the problems also exist for web, and whether these tests should be added to web too.

@guidezpl
Copy link
Member Author

For web, I never managed to get the driver.scrollUntilVisible command to work, and so the test will hang here https://github.com/flutter/gallery/blob/master/test_driver/transitions_perf_test.dart#L146 until it times out.

@guidezpl guidezpl merged commit 663a930 into master Jul 17, 2020
@guidezpl guidezpl deleted the crane-transitions-perf-test branch July 17, 2020 19:01
@liyuqian
Copy link
Contributor

When I tried to add this to Flutter's devicelab today, I found #227.

clocksmith pushed a commit to clocksmith/gallery that referenced this pull request Jul 23, 2020
@guidezpl guidezpl changed the title Add performance transitions test for crane only [Benchmarks] Add performance transitions test for crane only Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add focused performance test for Crane ListView scrollling

3 participants