This repository was archived by the owner on Jun 13, 2024. It is now read-only.
[Benchmarks] Add performance transitions test for crane only#216
Merged
[Benchmarks] Add performance transitions test for crane only#216
Conversation
rami-a
approved these changes
Jul 17, 2020
|
|
||
| final summary = TimelineSummary.summarize(timeline); | ||
| await summary.writeSummaryToFile('transitions-crane', pretty: true); | ||
| }); |
Contributor
There was a problem hiding this comment.
The all demos test has a timeout, should this one?
Member
Author
There was a problem hiding this comment.
I don't see why not, I'll add one
Member
Author
|
For web, I never managed to get the |
Contributor
|
When I tried to add this to Flutter's devicelab today, I found #227. |
clocksmith
pushed a commit
to clocksmith/gallery
that referenced
this pull request
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to perform the transitions test for Crane only.
To run the transitions_perf test for all demos:
flutter drive --profile --trace-startup -t test_driver/transitions_perf.dart -d <device>To run the transitions_perf test for just Crane:
flutter drive --profile --trace-startup -t test_driver/transitions_perf.dart -d <device> --dart-define=onlyCrane=trueSince --tags isn't yet supported for flutter driver tests and
skipisn't designed for runtime determination, this is the simplest way to conditionally run a driver test from the command line.Closes #214