[a11y-web] adding enabled to button semantics #219
Conversation
|
This is a quick fix for the gallery code before the july updates. However a better fix might be changing enabled to default true in this class: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/basic.dart#L6634 @goderbauer shall I also send a PR to the framework repo? |
|
I don't think this is the right fix. The bug appears to be here: Something should only be marked as disabled when the |
|
I would recommend reverting this change. It may have unintended a11y side-effects because (some of) the wrapped button already set this property: https://github.com/flutter/flutter/blob/5b9ce492f3da4a2b3a629ede34951bcac7d79a56/packages/flutter/lib/src/material/button.dart#L462 |
|
@goderbauer I see, so we were implementing it wrong on the engine side for a while. I'll revert this one. |
|
I took a closer look at where this PR is adding the Nevertheless, the web engine still has the bug that something is only disabled if |
…run for Flutter Gallery (flutter#219) * Add command to travis CI to analyze if update-code-segments has been run Former-commit-id: 6c10ea3
Web will add aria-disabled to these elements otherwise: https://github.com/flutter/engine/blob/master/lib/web_ui/lib/src/engine/semantics/tappable.dart#L27