This repository was archived by the owner on Jun 13, 2024. It is now read-only.
[Benchmarks] Add scrolling to Crane's performance test#228
Merged
Conversation
guidezpl
commented
Jul 22, 2020
| craneFlyList, | ||
| 0, | ||
| -1000, | ||
| const Duration(seconds: 1), |
Member
Author
There was a problem hiding this comment.
This looked pretty good to me on both mobile and desktop layouts
rami-a
approved these changes
Jul 22, 2020
| Future<void> runDemos(List<String> demos, FlutterDriver driver, | ||
| {bool scrollToTopWhenDone = false}) async { | ||
| {Future<void> Function() additionalActions, | ||
| bool scrollToTopWhenDone = true}) async { |
Contributor
There was a problem hiding this comment.
Nit: Perhaps a trailing comma for better formatting
liyuqian
approved these changes
Jul 22, 2020
Contributor
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
LGTM!
I tried it on Moto G4 locally and got the following result where 1/3 of frame build times are out of budget, and the 90th-percentile is 25ms. It seems that we do have some room to improve the performance here.
"average_frame_build_time_millis": 14.245278688524587,
"90th_percentile_frame_build_time_millis": 25.351,
"99th_percentile_frame_build_time_millis": 42.481,
"worst_frame_build_time_millis": 94.018,
"missed_frame_build_budget_count": 23,
"average_frame_rasterizer_time_millis": 8.706786885245902,
"90th_percentile_frame_rasterizer_time_millis": 19.511,
"99th_percentile_frame_rasterizer_time_millis": 26.885,
"worst_frame_rasterizer_time_millis": 65.748,
"missed_frame_rasterizer_budget_count": 7,
"frame_count": 61,
"frame_rasterizer_count": 61,
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Jul 23, 2020
For flutter#61193 This also rolls the new Gallery app's version to include flutter/gallery#228
guidezpl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for running additional actions during the driver performance transitions test
Adds a scrolling action to the Crane-only transitions test
Fixes #227