This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Updates to the Reply Navigation Rail animation#299
Merged
clocksmith merged 11 commits intoflutter:masterfrom Sep 16, 2020
Merged
Updates to the Reply Navigation Rail animation#299clocksmith merged 11 commits intoflutter:masterfrom
clocksmith merged 11 commits intoflutter:masterfrom
Conversation
| extended: _isExtended.value, | ||
| labelType: NavigationRailLabelType.none, | ||
| leading: _NavigationRailHeader( | ||
| extended: _isExtended, |
Contributor
There was a problem hiding this comment.
nit: can _NavigationRailHeader fit on one line?
| const SizedBox(height: 8), | ||
| for (var folder in folders.keys) | ||
| InkWell( | ||
| borderRadius: const BorderRadius.all( |
Contributor
There was a problem hiding this comment.
nit: can borderRadius fit on one line?
Renzo-Olivares
approved these changes
Sep 15, 2020
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
This is Awesome!
LGTM
…y-nav-rail-animation
…y-nav-rail-animation
perclasson
pushed a commit
to perclasson/gallery
that referenced
this pull request
Sep 16, 2020
* Use google_fonts package * Use hosted version of google_fonts Former-commit-id: 73f8984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes a few updates to the Nav Rail extended animation:
The destinations also no longer jump by a combination of flutter/flutter#65659 and correcting the leading animation.
Before regular speed:
After regular speed:
Before 5x slow speed:
After 5x slow speed: