This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Merged
Conversation
JoseAlba
approved these changes
Sep 16, 2020
Contributor
JoseAlba
left a comment
JoseAlba
left a comment
There was a problem hiding this comment.
██╗ ██████╗ ████████╗███╗ ███╗
██║ ██╔════╝ ╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
guidezpl
approved these changes
Sep 16, 2020
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
perclasson
pushed a commit
to perclasson/gallery
that referenced
this pull request
Sep 16, 2020
Former-commit-id: 2a1ad46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
CardDemoType→CardTypetype→cardTypeallowing DartPad code generator to better understand them.
Explanation
The DartPad code generator looks for all variables named
typeand replaces them with a specific demo type; for example, inmaterial/dialog_demo.dart, the variabletypealways refer to the type of the demo we are running (one ofalert,alertTitle,simple,fullscreen), so the code generator will replacetypewithDialogDemoType.alert,DialogDemoType.alertTitle,DialogDemoType.simple, andDialogDemoType.fullscreenin order to generate standalone apps for each demo type.Since the
typeinmaterial/cards_demo.dartrefers to the type of the card we use, instead of the type of the demo, renaming it tocardTypeallows the code generator to avoid replacing them.