Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Create release draft on new tags with desktop applications and apk attached#314

Merged
perclasson merged 24 commits intoflutter:masterfrom
perclasson:release_on_tags
Sep 18, 2020
Merged

Create release draft on new tags with desktop applications and apk attached#314
perclasson merged 24 commits intoflutter:masterfrom
perclasson:release_on_tags

Conversation

@perclasson
Copy link
Contributor

@perclasson perclasson commented Sep 18, 2020

Simplifies the release process to automatically create release drafts with desktop applications and apk included:

  • Create release draft when a tag is added
  • Update os to use fixed version instead of latest (a Google best practice)

Relates to #43

Was tested on my personal repo https://github.com/perclasson/gallery/actions/runs/261192033, see finished example release:
https://github.com/perclasson/gallery/releases/tag/v2.8

@guidezpl
Copy link
Member

So neat!

Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

@perclasson perclasson merged commit 699d2cc into flutter:master Sep 18, 2020
working-directory: code/${{ matrix.path }}
- name: Compress build for Windows
if: startsWith(matrix.os, 'windows')
run: compress-archive -Path * -DestinationPath ${env:GITHUB_WORKSPACE}\flutter_gallery_${{ matrix.target }}.zip
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this won't run for all users; see https://github.com/flutter/flutter/wiki/Desktop-shells#distributing

If a zip is the distribution method the C++ redistributables should be included in it (i.e., copied into this folder before making the archive).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@stuartmorgan I'm adding them here: #320

gspencergoog pushed a commit to gspencergoog/gallery that referenced this pull request Sep 23, 2020
…fore (flutter#314)

* Update desktop Rally for pages that did not have designs before

Former-commit-id: d85d839
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants