This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Fix floating action button tag conflict in Reply (#316)#318
Merged
pennzht merged 2 commits intoflutter:masterfrom Sep 21, 2020
Merged
Fix floating action button tag conflict in Reply (#316)#318pennzht merged 2 commits intoflutter:masterfrom
pennzht merged 2 commits intoflutter:masterfrom
Conversation
JoseAlba
approved these changes
Sep 21, 2020
Contributor
JoseAlba
left a comment
JoseAlba
left a comment
There was a problem hiding this comment.
██╗ ██████╗ ████████╗███╗ ███╗
██║ ██╔════╝ ╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
guidezpl
approved these changes
Sep 21, 2020
gspencergoog
pushed a commit
to gspencergoog/gallery
that referenced
this pull request
Sep 23, 2020
* Move gallery/gallery/ content to gallery/ * Update banner_demo.dart * Update documentation * Add hidden files * Edit Travis script * Update top level docs * Update README.md path * Move Crane middle tab up Former-commit-id: 13c3bbc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this PR carefully and make sure it does not change any existing behavior/logic/animations.
Thank you!
Description
Add a
heroTagfor the "Back" floating action button, so that the two floating action buttons ("Back" and_ReplyFab) do not share the same tag (_DefaultHeroTag).Issue
Closes #316