Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Include Visual C++ redistributables for Windows build#320

Merged
perclasson merged 2 commits intoflutter:masterfrom
perclasson:copy_vc_redistributables
Sep 22, 2020
Merged

Include Visual C++ redistributables for Windows build#320
perclasson merged 2 commits intoflutter:masterfrom
perclasson:copy_vc_redistributables

Conversation

@perclasson
Copy link
Contributor

@perclasson perclasson commented Sep 22, 2020 •
edited
Loading

From https://github.com/flutter/flutter/wiki/Desktop-shells#distributing

Include the Visual C++ redistributables for Windows build.

As I understand it Flutter only supports x64 and we want to use the latest MSVC. From running vswhere we have the following options (I chose \VC\Redist\MSVC\14.27.29016\x64\Microsoft.VC142.CRT):

2020-09-22T11:19:43.5711041Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\arm\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5713867Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\arm64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5715411Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\arm\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5716476Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\arm64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5717586Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\x64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5718617Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\x86\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5719645Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\arm\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5720688Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\arm64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5721758Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\arm\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5723306Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\arm64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5724393Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\x64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5725505Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\x86\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5726556Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\x64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5727587Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\x86\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5730102Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\x64\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5731077Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\x86\Microsoft.VC141.CRT\msvcp140.dll
2020-09-22T11:19:43.5732057Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\onecore\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5733081Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\onecore\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5734081Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5735255Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5736934Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\arm64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5737927Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\arm\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5738891Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\arm64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5739852Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5740794Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5741775Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\arm\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5742799Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\arm64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5743817Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5745223Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5746408Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5837256Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5838901Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\x64\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.5840034Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\x86\Microsoft.VC142.CRT\msvcp140.dll
2020-09-22T11:19:43.6869088Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\arm\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6870896Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\arm64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6873290Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\arm\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6875352Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\arm64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6876907Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\x64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6878423Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\onecore\x86\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6880728Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\arm\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6882217Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\arm64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6884363Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\arm\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6886203Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\arm64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6887745Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\x64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6889832Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\onecore\x86\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6891832Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\x64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6894704Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\spectre\x86\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6896240Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\x64\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6897461Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.16.27012\x86\Microsoft.VC141.CRT\vcruntime140.dll
2020-09-22T11:19:43.6898676Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\onecore\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6899938Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\onecore\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6901241Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6902333Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6903427Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\arm64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6904562Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\arm\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6905945Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\arm64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6907172Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6908288Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6909286Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\arm\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6911498Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\arm64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6913728Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6916277Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6918155Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6919894Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6921343Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\x64\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.6924398Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\x86\Microsoft.VC142.CRT\vcruntime140.dll
2020-09-22T11:19:43.7920496Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\onecore\x64\Microsoft.VC142.CRT\vcruntime140_1.dll
2020-09-22T11:19:43.7922946Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.25.28508\x64\Microsoft.VC142.CRT\vcruntime140_1.dll
2020-09-22T11:19:43.7924600Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\onecore\x64\Microsoft.VC142.CRT\vcruntime140_1.dll
2020-09-22T11:19:43.7926070Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\onecore\x64\Microsoft.VC142.CRT\vcruntime140_1.dll
2020-09-22T11:19:43.7927572Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\spectre\x64\Microsoft.VC142.CRT\vcruntime140_1.dll
2020-09-22T11:19:43.7929777Z C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.27.29016\x64\Microsoft.VC142.CRT\vcruntime140_1.dll

@perclasson perclasson mentioned this pull request Sep 22, 2020
Merged
JoseAlba
JoseAlba approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@JoseAlba JoseAlba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

stuartmorgan-g
stuartmorgan-g approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it would be done as part of the build so that it could use the path to the VS installation being used for the build, but this seems reasonable as well. It might need updates as the exact versions of things installed on the image change, but presumably that's rare.

@perclasson perclasson merged commit 6f6bd1c into flutter:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@rami-a rami-a rami-a approved these changes

@JoseAlba JoseAlba JoseAlba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@perclasson @stuartmorgan-g @rami-a @JoseAlba