Added Navigation Rail demo to Material section#342
Added Navigation Rail demo to Material section#342clocksmith merged 12 commits intoflutter:masterfrom Alabhya268:master
Conversation
|
Please let me know if anything needs to be changed. |
|
@rami-a could you please have a look at this PR. |
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
Thanks for another contribution @Alabhya268 ! Looks pretty good but could you address my feedback please :)
I've made necessary changes please have a look . |
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM, just one small comment :)
| selectedIndex: _selectedIndex, | ||
| onDestinationSelected: (index) { | ||
| setState( | ||
| () { |
There was a problem hiding this comment.
nit: can this be moved up 1 line?
| }, | ||
| ); | ||
| }, | ||
| labelType: NavigationRailLabelType.selected, |
There was a problem hiding this comment.
Good choice for this demo!
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM with one last tiny nit, thanks!
| children: [ | ||
| NavigationRail( | ||
| leading: FloatingActionButton( | ||
| child: const Icon(Icons.add), onPressed: () {}), |
There was a problem hiding this comment.
Nit: Add a trailing comma and reformat.
There was a problem hiding this comment.
also thanks for guiding me.
3 participants
Gallery Side - Closes #190