Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

[Reply] Fix lines around MailBody when width cap is exceeded#445

Merged
guidezpl merged 4 commits intoflutter:masterfrom
Renzo-Olivares:reply_cap_fix
Mar 2, 2021
Merged

[Reply] Fix lines around MailBody when width cap is exceeded#445
guidezpl merged 4 commits intoflutter:masterfrom
Renzo-Olivares:reply_cap_fix

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Feb 28, 2021

The SharedAxisTransition widget has a property called fillColor which is the background color used during the transition. This fillColor looks like it also outlines the widget it contains, so here I change it to match the background of the background so they are no longer visible.

This change fixes the bug introduced in #425. Where faint lines would surround the MailBody (see below) when exceeding the new 1340 width cap.

Before After
capexample fixeddddddd

…ates lines around mailbody when expanded past 1340 cap
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without the goldens

@guidezpl guidezpl merged commit 5e928fe into flutter:master Mar 2, 2021
@guidezpl
Copy link
Member

guidezpl commented Mar 2, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants