This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Fix[study-wrapper]: Back button overlapping#522
Merged
guidezpl merged 2 commits intoflutter:masterfrom Jun 22, 2021
Merged
Conversation
guidezpl
approved these changes
Jun 22, 2021
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Makes the study more usable, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the overlapping "Back" button with the bottom navigation bar problem.
I am not really happy with my solution because it does not cover the case where the bottom bar is no longer there (when the user scrolls and when we are in desktop display).
I would love to get your feedback and know how I could improve this.