Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Fix two null safety analysis issues and update goldens#596

Merged
guidezpl merged 3 commits intoflutter:masterfrom
devoncarew:fix_analysis
Feb 7, 2022
Merged

Fix two null safety analysis issues and update goldens#596
guidezpl merged 3 commits intoflutter:masterfrom
devoncarew:fix_analysis

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Feb 5, 2022 •
edited
Loading

Fix two null safety analysis issues.

List which issues are fixed by this PR. You must list at least one issue.

warning • The receiver can't be null, so the null-aware operator '?.' is unnecessary •
       lib/feature_discovery/feature_discovery.dart:224:34 • invalid_null_aware_operator
warning • The receiver can't be null, so the null-aware operator '?.' is unnecessary •
       lib/feature_discovery/feature_discovery.dart:240:36 • invalid_null_aware_operator

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@devoncarew devoncarew requested a review from guidezpl February 6, 2022 05:33
@guidezpl
Copy link
Member

guidezpl commented Feb 7, 2022

Integrated the changes from #597 to fix the test deadlock

@guidezpl guidezpl changed the title fix two null safety analysis issues Fix two null safety analysis issues and update goldens Feb 7, 2022
@guidezpl guidezpl merged commit 1146647 into flutter:master Feb 7, 2022
@devoncarew
Copy link
Contributor Author

devoncarew commented Feb 7, 2022

Thanks for fixing the PR up can landing it!

I'm assuming it's only a smaller set of folks that can trigger the repo's checks?

@guidezpl
Copy link
Member

guidezpl commented Feb 7, 2022

I think so, but I don't have access to those settings. @godofredoc might know more

@guidezpl guidezpl mentioned this pull request Feb 10, 2022
Closed
@copperyp
Copy link

copperyp commented Feb 11, 2022 •
edited
Loading

Hi guidezpl

build & run fail :(

cd gallery
flutter config --enable-windows-desktop
flutter pub get
flutter run -d windows

lib/feature_discovery/feature_discovery.dart(224,35): error G0EB489DC: Method 'addPostFrameCallback' cannot be called on 'SchedulerBinding?' because it is p
otentially null. [D:\src\gallery\build\windows\flutter\flutter_assemble.vcxproj]
lib/feature_discovery/feature_discovery.dart(240,37): error G0EB489DC: Method 'addPostFrameCallback' cannot be called on 'SchedulerBinding?' because it is p
otentially null. [D:\src\gallery\build\windows\flutter\flutter_assemble.vcxproj]

env
[√] Flutter (Channel stable, 2.10.1, on Microsoft Windows [Version 10.0.19044.1526], locale zh-CN)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.9)
[√] Android Studio (version 4.2)
[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
[√] Connected device (4 available)
[√] HTTP Host Availability

• No issues found!

i revert file [feature_discovery.dart] to previous was build & run success!

@guidezpl
Copy link
Member

guidezpl commented Feb 11, 2022

Please read the README

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso approved these changes

@guidezpl guidezpl guidezpl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devoncarew @guidezpl @copperyp @zanderso