This repository was archived by the owner on Jun 13, 2024. It is now read-only.
refactor : migrate all remaining demos #618
Merged
guidezpl merged 9 commits intoflutter:masterfrom Mar 29, 2022
Merged
Conversation
amanv8060
commented
Mar 14, 2022
amanv8060
force-pushed
the
more_migrations
branch
from
43c4357 to
2f4d088
Compare
amanv8060
commented
Mar 26, 2022
Contributor
Author
|
Hi @guidezpl , can you please review and run the code segments generator on your machine |
Contributor
Author
|
this pr can be a little better done, will do the changes today. |
amanv8060
changed the title
amanv8060
changed the title
guidezpl
reviewed
Mar 28, 2022
| final RestorableBool _sortAscending = RestorableBool(true); | ||
| final RestorableIntN _sortColumnIndex = RestorableIntN(null); | ||
| _DessertDataSource _dessertsDataSource; | ||
| _DessertDataSource? _dessertsDataSource; |
Contributor
Author
There was a problem hiding this comment.
so currently(before migration) we are only assigning with fresh values only if it's null, making late would make it reassign every time in didChangeDependencies and restoreState, so should I do it ?
Member
There was a problem hiding this comment.
Ah gotcha, then I would leave as is
guidezpl
reviewed
Mar 28, 2022
| @@ -83,51 +81,52 @@ class _DataTableDemoState extends State<DataTableDemo> with RestorationMixin { | |||
| _dessertsDataSource ??= _DessertDataSource(context); | |||
Member
There was a problem hiding this comment.
Suggested change
| _dessertsDataSource ??= _DessertDataSource(context); | |
| _dessertsDataSource = _DessertDataSource(context); |
guidezpl
reviewed
Mar 28, 2022
guidezpl
reviewed
Mar 28, 2022
guidezpl
suggested changes
Mar 28, 2022
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
Great, LGTM! Factoring out GalleryLocalizations.of(context) in many places cleans things up nicely as well
guidezpl
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates cupertino and material demoes
part of #527
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.