This repository was archived by the owner on Jun 13, 2024. It is now read-only.
refactor: remaining code migrated to null safety#624
Merged
guidezpl merged 3 commits intoflutter:masterfrom Mar 30, 2022
Merged
refactor: remaining code migrated to null safety#624guidezpl merged 3 commits intoflutter:masterfrom
guidezpl merged 3 commits intoflutter:masterfrom
Conversation
amanv8060
force-pushed
the
remaining_migrations
branch
from
a0f5b6b to
67d94ab
Compare
guidezpl
reviewed
Mar 30, 2022
Member
|
LGTM! Is there anything else to do? |
guidezpl
approved these changes
Mar 30, 2022
Contributor
Author
|
no, will migrate the tests this week as well. |
Member
|
thanks you so much! |
Contributor
Author
|
this has caused an issue, looks like tests are passing, but the app doesn't run for me. can this be reverted? |
8 tasks
Member
|
all works fine with #625, I went through the whole app and only found one other bug: if you open settings in the upper right, selecting a different text scaling option. Do you mind taking a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: remaining code migrated to null safety leaving tests to be migrated
part of #527
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.