Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

refactor: migrate test , test_driver , test_goldens #627

Merged
guidezpl merged 2 commits intoflutter:masterfrom
amanv8060:migrate_test
Apr 1, 2022
Merged

refactor: migrate test , test_driver , test_goldens #627
guidezpl merged 2 commits intoflutter:masterfrom
amanv8060:migrate_test

Conversation

@amanv8060
Copy link
Contributor

@amanv8060 amanv8060 commented Mar 30, 2022 •
edited
Loading

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

part of #527

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@amanv8060
Copy link
Contributor Author

amanv8060 commented Mar 30, 2022

Output of : flutter drive --profile --trace-startup -t test_driver/transitions_perf.dart -d <device>

Logs 
Running "flutter pub get" in gallery...                            12.1s
Shrinking has been disabled for this build due to deferred components. Shrinking is not available for multi-apk applications. This limitation is expected to be removed when Gradle plugin 4.2+ is available in Flutter.
../../../../.pub-cache/hosted/pub.dartlang.org/animations-2.0.2/lib/src/open_container.dart:631:24: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../flutterm/packages/flutter/lib/src/scheduler/binding.dart').
      SchedulerBinding.instance!
                       ^
../../../../.pub-cache/hosted/pub.dartlang.org/animations-2.0.2/lib/src/open_container.dart:665:24: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../flutterm/packages/flutter/lib/src/scheduler/binding.dart').
      SchedulerBinding.instance!
                       ^
Running Gradle task 'assembleProfile'...                           64.5s
✓  Built build/app/outputs/flutter-apk/app-profile.apk (96.5MB).
Installing build/app/outputs/flutter-apk/app.apk...                10.4s
W/FlutterActivityAndFragmentDelegate(28300): A splash screen was provided to Flutter, but this is deprecated. See flutter.dev/go/android-splash-migration for migration steps.
D/ViewRootImpl[MainActivity](28300): hardware acceleration = true , fakeHwAccelerated = false, sRendererDisabled = false, forceHwAccelerated = false, sSystemRendererDisabled = false
D/DecorView[](28300): getWindowModeFromSystem  windowmode is 1
I/InputTransport(28300): Create ARC handle: 0xb40000707547ee20
V/PhoneWindow(28300): DecorView setVisiblity: visibility = 0, Parent = android.view.ViewRootImpl@88b20bf, this = DecorView@9f1538c[MainActivity]
W/Looper  (28300): PerfMonitor looperActivity : package=io.flutter.demo.gallery/.MainActivity time=254ms latency=351ms running=142ms  procState=2 ClientTransaction{ callbacks=[android.app.servertransaction.LaunchActivityItem]
lifecycleRequest=android.app.servertransaction.ResumeActivityItem } historyMsgCount=1 (msgIndex=1 wall=351ms seq=3 running=193ms runnable=122ms late=4ms h=android.app.ActivityThread$H w=110)
W/Looper  (28300): PerfMonitor looperActivity : package=io.flutter.demo.gallery/.MainActivity time=0ms latency=606ms running=0ms  procState=2 ClientTransaction{ callbacks=[android.app.servertransaction.TopResumedActivityChangeItem]
} historyMsgCount=2 (msgIndex=1 wall=351ms seq=3 running=193ms runnable=122ms late=4ms h=android.app.ActivityThread$H w=110) (msgIndex=2 wall=254ms seq=4 running=142ms runnable=22ms late=351ms h=android.app.ActivityThread$H w=159)
D/libMEOW (28300): applied 1 plugins for [io.flutter.demo.gallery]:
D/libMEOW (28300):   plugin 1: [libMEOW_gift.so]:
D/SurfaceView(28300): UPDATE null, mIsCastMode = false
I/GED     (28300): [GT]_get_procNameprocess pid(28300)
I/GED     (28300): [GT]_getprocess name(io.flutter.demo.gallery)
I/er.demo.galler(28300): [GT] ret(1) gt_status(00000000) aniso_debug_level(0) gt_aniso_max_level(16) ani so mask(00000001) tri mask(00000002)
I/libMEOW_gift(28300): ctx:0xb400007029d16f20, ARC not Enabled.
D/libMEOW (28300): applied 1 plugins for [io.flutter.demo.gallery]:
D/libMEOW (28300):   plugin 1: [libMEOW_gift.so]:
E/ion     (28300): ioctl c0044901 failed with code -1: Invalid argument
00:00 +0: Flutter Gallery transitions (setUpAll)

VMServiceFlutterDriver: Connecting to Flutter application at http://127.0.0.1:40295/9dKNEu9EAV0=/
VMServiceFlutterDriver: Isolate found with number: 3414810770675599
VMServiceFlutterDriver: Isolate is paused at start.
VMServiceFlutterDriver: Attempting to resume isolate
VMServiceFlutterDriver: Connected to Flutter application.
00:00 +0: Flutter Gallery transitions only Crane

00:00 +1: Flutter Gallery transitions only Reply

00:00 +2: Flutter Gallery transitions all demos

> reply@study
scrolling to demo
tapping demo
tapping demo
< Success
> shrine@study
scrolling to demo
tapping demo
tapping demo
< Success
> rally@study
scrolling to demo
tapping demo
tapping demo
< Success
> crane@study
scrolling to demo
tapping demo
I/er.demo.galler(28300): ProcessProfilingInfo new_methods=1179 is saved saved_to_disk=1 resolve_classes_delay=8000
tapping demo
< Success
> fortnightly@study
scrolling to demo
tapping demo
tapping demo
< Success
> bottom-navigation@material
scrolling to top
scrolling to material category
scrolling to demo
tapping demo
tapping demo
< Success
> button@material
scrolling to demo
tapping demo
tapping demo
< Success
> card@material
scrolling to demo
tapping demo
tapping demo
< Success
> chip@material
scrolling to demo
tapping demo
tapping demo
< Success
> dialog@material
scrolling to demo
tapping demo
tapping demo
< Success
> pickers@material
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-alerts@cupertino
scrolling to top
scrolling to cupertino category
scrolling to demo
tapping demo
tapping demo
< Success
> colors@other
scrolling to top
scrolling to other category
scrolling to demo
tapping demo
tapping demo
< Success
scrolling to top
I/er.demo.galler(28300): Compiler allocated 4379KB to compile void android.view.ViewRootImpl.performTraversals()
> starter@study
scrolling to demo
tapping demo
tapping demo
< Success
> app-bar@material
scrolling to top
scrolling to material category
scrolling to demo
tapping demo
tapping demo
< Success
> banner@material
scrolling to demo
tapping demo
tapping demo
< Success
> bottom-app-bar@material
scrolling to demo
tapping demo
tapping demo
< Success
> bottom-sheet@material
scrolling to demo
tapping demo
tapping demo
< Success
> data-table@material
scrolling to demo
tapping demo
tapping demo
< Success
> divider@material
scrolling to demo
tapping demo
tapping demo
< Success
> grid-lists@material
scrolling to demo
tapping demo
tapping demo
< Success
> lists@material
scrolling to demo
tapping demo
tapping demo
< Success
> menu@material
scrolling to demo
tapping demo
tapping demo
< Success
> nav_drawer@material
scrolling to demo
tapping demo
tapping demo
< Success
> nav_rail@material
scrolling to demo
tapping demo
tapping demo
< Success
> progress-indicator@material
scrolling to demo
tapping demo
tapping demo
< Success
> selection-controls@material
scrolling to demo
tapping demo
tapping demo
< Success
> sliders@material
scrolling to demo
tapping demo
tapping demo
< Success
> snackbars@material
scrolling to demo
tapping demo
tapping demo
< Success
> tabs@material
scrolling to demo
tapping demo
tapping demo
< Success
> text-field@material
scrolling to demo
tapping demo
tapping demo
< Success
> tooltip@material
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-activity-indicator@cupertino
scrolling to top
scrolling to cupertino category
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-buttons@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-context-menu@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-navigation-bar@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-picker@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-pull-to-refresh@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-segmented-control@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-slider@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-switch@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-tab-bar@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> cupertino-text-field@cupertino
scrolling to demo
tapping demo
tapping demo
< Success
> motion@other
scrolling to top
scrolling to other category
scrolling to demo
tapping demo
tapping demo
< Success
> typography@other
scrolling to demo
tapping demo
tapping demo
< Success
> 2d-transformations@other
scrolling to demo
tapping demo
tapping demo
< Success
scrolling to top
02:42 +3: Flutter Gallery transitions (tearDownAll)

Timeline summaries for profiled demos have been output to the build/ directory.
02:42 +3: All tests passed!

@amanv8060
Copy link
Contributor Author

amanv8060 commented Mar 30, 2022

test_benchmarks migration is blocked on flutter/packages#879

@amanv8060
Copy link
Contributor Author

amanv8060 commented Apr 1, 2022

@guidezpl, this can be merged?

@guidezpl
Copy link
Member

guidezpl commented Apr 1, 2022

yes!

@guidezpl guidezpl merged commit 7452f28 into flutter:master Apr 1, 2022
@amanv8060 amanv8060 deleted the migrate_test branch April 1, 2022 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@guidezpl guidezpl guidezpl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amanv8060 @guidezpl