This repository was archived by the owner on Jun 13, 2024. It is now read-only.
allow picking a renderer using a query parameter#691
Merged
Conversation
ditman
reviewed
May 18, 2022
ditman
approved these changes
May 18, 2022
ditman
approved these changes
May 18, 2022
ditman
reviewed
May 18, 2022
web/index.html
Outdated
Comment on lines
+37
to
+39
| let query = window.location.search; | ||
| if (query) { | ||
| let searchParams = new URLSearchParams(query); |
Member
There was a problem hiding this comment.
URLSearchParams seems to support a nullable string passed in, so you could potentially just do:
let searchParams = new URLSearchParams(window.location.search);
if (searchParams.has('renderer') {
...
}
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
?renderer=htmlor?renderer=canvaskitin the URL will select the respective renderer instead of picking one automatically.