This repository was archived by the owner on Jun 13, 2024. It is now read-only.
add missing const to constructor invocation#878
Merged
pq merged 1 commit intoflutter:mainfrom Feb 1, 2023
Merged
Conversation
Contributor
|
test-exempt: code refactor with no semantic change |
Member
|
Curious: What was fixed in the linter to get this one flagged? |
Contributor
Author
|
(For the curious, from a chat w/ @goderbauer)
Wrap is now const, so in the gallery snippet the const was able to move higher up in the tree. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 7, 2023
Some notes. * There are a number of tests that should get decoupled from the linter being pulled into `DEPS`. Instead of depending on the state of lints there, we should update the tests instead to use a more hermetic environment. (See for example `options_rule_validator_test.dart` for how that might look.) Downstream (blocking) fixes: * flutter/flutter#119736 * flutter/gallery#878 Change-Id: I5671b0abde3eeda75513abaaf9fef3bcd5115f9b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280054 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Paul Berry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
constconstructor invocation before it's flagged by an incoming linter.See failure: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8790348913643501601/+/u/analyze_flutter_gallery/stdout
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.