Added superellipse_shape golden image (#26295)#23
Merged
dnfield merged 2 commits intoflutter:masterfrom Jan 9, 2019
Merged
Conversation
Contributor
|
Would it make sense to add a few with different parameters? |
Salby
force-pushed
the
superellipse_shape
branch
from
12b889a to
df0b400
Compare
Contributor
Author
|
I added another test that has some uneven radii. Not sure how many we really need. |
Contributor
|
Could you do one more with a larger radius? That should be good. |
Salby
force-pushed
the
superellipse_shape
branch
from
f833b1b to
7ad31b3
Compare
Contributor
|
Great! LGTM |
Contributor
|
(You'll have to update the goldens hash in your PR on flutter/flutter now to pull this in for the testing) |
Contributor
Author
|
Should I delete this branch now? |
Contributor
|
You can, up to you really |
Contributor
Author
|
I understand :) thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added golden image used for testing by superellipse_shape.