This repository was archived by the owner on Apr 29, 2022. It is now read-only.
Fix enum typedef for older mac SDKs#136
Merged
dnfield merged 4 commits intoflutter:mainfrom Apr 14, 2022
Merged
Conversation
Merged
jmagman
reviewed
Apr 14, 2022
| // machines with lower SDK versions than 11.0.s | ||
| #if !defined(MAC_OS_X_VERSION_11_0) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_11_0 | ||
| typedef enum MTLCommandEncoderErrorState : NSInteger { | ||
| #if !defined(MAC_OS_VERSION_11_0) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_11_0 |
Member
There was a problem hiding this comment.
All Mac engine builders except for the Mac Web Engine are running Xcode 13 (which has MAC_OS_VERSION_11_0 defined)
https://github.com/flutter/engine/blob/289368cadccbce88913b3ab279ed754d705740f9/.ci.yaml#L73
Mac Web Engine Xcode migration blocked on flutter/flutter#99885
https://github.com/flutter/engine/blob/289368cadccbce88913b3ab279ed754d705740f9/.ci.yaml#L327
Contributor
Author
There was a problem hiding this comment.
Need a guard for the macOS 12 defines too
Contributor
Author
There was a problem hiding this comment.
So once Mac Web engine rolls we can remove the first block here - we won't be able to remove the second until we further upgrade.
Contributor
Author
|
With this patch applied all impeller related failures on flutter/engine#32658 are resolved. |
zanderso
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I .. I forget how to write ObjC.
I'm going to let CI finish on flutter/engine#32658 (which currently points to my fork) before landing this.