[various] Standardize Gradle namespace#10084
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Sep 26, 2025
Merged
Conversation
Standardizes namespace on the `=` form of property assignment, and updates the existing namespace check to require that version. Also standardizes these lines on `"` rather than `'` while touching them. Part of flutter/flutter#176065
stuartmorgan-g
added
override: no versioning needed
stuartmorgan-g
requested review from
Hixie,
Piinks,
ash2moon,
bparrishMines,
camsim99,
chunhtai,
domesticmouse,
gmackall,
jesswrd,
mboetger,
reidbaker and
tarrinneal
as code owners
Collaborator
Author
|
CHANGELOG/version override: this is a no-op style change, so doesn't impact clients. |
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: pigeon
p: rfw
github-actions
bot
added
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
stuartmorgan-g
commented
Sep 26, 2025
| signingConfig signingConfigs.debug | ||
| } | ||
| } | ||
| namespace 'com.example.example' |
Collaborator
Author
There was a problem hiding this comment.
This example app had somehow ended up with two namespaces.
domesticmouse
approved these changes
Sep 26, 2025
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the Gradle namespace property to use the = assignment form and double quotes across numerous build.gradle files. It also updates the gradle-check tool to enforce this new convention. The changes are well-executed and improve consistency. I've found one issue in the test suite where a test case is not correctly asserting a failure, which could lead to undetected regressions.
reidbaker
approved these changes
Sep 26, 2025
| /// compatibility with apps that use AGP 8+. | ||
| bool _validateNamespace(RepositoryPackage package, String gradleContents, | ||
| {required bool isExample}) { | ||
| // Regex to validate that either of the following namespace definitions |
Contributor
There was a problem hiding this comment.
Did you mean to delete "of"
Collaborator
Author
There was a problem hiding this comment.
I meant to rewrite the sentence more than I did; I'm not sure what happened.
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/10084, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
stuartmorgan-g
changed the title
namespacenamespace
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2025
flutter/packages@389c678...34eec78 2025-09-29 [email protected] [camera_android_camerax] Implement setDescriptionWhileRecording (flutter/packages#10030) 2025-09-29 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10114) 2025-09-27 [email protected] [various] Standardize Java compat in Gradle (flutter/packages#10091) 2025-09-26 [email protected] [various] Standardize gradle dependencies (flutter/packages#10083) 2025-09-26 [email protected] [go_router_builder] Ignore upcoming `experimental_member_use` warnings. (flutter/packages#10082) 2025-09-26 [email protected] [various] Standardize Gradle `namespace` (flutter/packages#10084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@389c678...34eec78 2025-09-29 [email protected] [camera_android_camerax] Implement setDescriptionWhileRecording (flutter/packages#10030) 2025-09-29 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.0.21 to 2.2.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10114) 2025-09-27 [email protected] [various] Standardize Java compat in Gradle (flutter/packages#10091) 2025-09-26 [email protected] [various] Standardize gradle dependencies (flutter/packages#10083) 2025-09-26 [email protected] [go_router_builder] Ignore upcoming `experimental_member_use` warnings. (flutter/packages#10082) 2025-09-26 [email protected] [various] Standardize Gradle `namespace` (flutter/packages#10084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes namespace on the
=form of property assignment, and updates the existing namespace check to require that version.Also standardizes these lines on
"rather than'while touching them.Part of flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3