Instruct agents to create a repo root alias#10165
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Oct 3, 2025
Merged
Instruct agents to create a repo root alias#10165auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
In my trials so far, Jules struggles to run the repo tooling commands once it has moved into a target directory, because it frequently tries to use a root-relative path instead of an absolute path. To try to reduce that problem, this instructs the agent to explicitly create an alias so that the later commands that reference REPO_ROOT as a placeholder will, hopefully, be run exactly as written in the examples instead. Also, to reduce unnecessary working directory confusion, switch to `dart pub get -C` instead of `cd` followed by `dart pub get` for initializing the tooling. (Also makes the same change to the tool README, because why not have humans run one command instead of three.)
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates setup instructions in AGENTS.md and script/tool/README.md. It introduces a command to define a REPO_ROOT environment variable in AGENTS.md. It also replaces a multi-command sequence involving cd and dart pub get with a single dart pub get -C command in both files. I have provided one comment to suggest a terminology clarification in the documentation for accuracy.
AGENTS.md
Outdated
Comment on lines
+43
to
+45
| First, define an alias for the repository root directory and initialize the tooling: | ||
| ```bash | ||
| cd $REPO_ROOT/script/tool # $REPO_ROOT is the repository root | ||
| dart pub get | ||
| # Define an alias for the repository root. |
There was a problem hiding this comment.
For improved accuracy, it's better to call REPO_ROOT an 'environment variable' instead of an 'alias'. In shell scripting, an alias is a shortcut for a command, whereas export creates an environment variable that holds a value. This change updates the terminology in both the description and the code comment for correctness.
Suggested change
| First, define an alias for the repository root directory and initialize the tooling: | |
| ```bash | |
| cd $REPO_ROOT/script/tool # $REPO_ROOT is the repository root | |
| dart pub get | |
| # Define an alias for the repository root. | |
| First, define an environment variable for the repository root directory and initialize the tooling: | |
| ```bash | |
| # Define an environment variable for the repository root. |
Collaborator
Author
There was a problem hiding this comment.
Entertainingly, the use of "alias" came from Gemini in the first place 🤷🏻 I left it alone before because it was a Gemini suggestion, so I was trusting the model, but it seems like maybe it was a quirk of my prompt rather than a model preference so I've changed it to be accurate.
tarrinneal
approved these changes
Oct 3, 2025
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 6, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Oct 7, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@e401aeb...d3ef88b 2025-10-06 [email protected] Roll Flutter from 5c0c9e9 to 908012d (18 revisions) (flutter/packages#10175) 2025-10-03 [email protected] Manual roll Flutter from 65aca36 to 5c0c9e9 (16 revisions) (flutter/packages#10170) 2025-10-03 [email protected] Instruct agents to create a repo root alias (flutter/packages#10165) 2025-10-03 [email protected] [Gradle 9] Fixed Gradle 9 Deprecations in Packages (flutter/packages#10016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my trials so far, Jules struggles to run the repo tooling commands once it has moved into a target directory, because it frequently tries to use a root-relative path instead of an absolute path. To try to reduce that problem, this instructs the agent to explicitly create an alias so that the later commands that reference REPO_ROOT as a placeholder will, hopefully, be run exactly as written in the examples instead.
Also, to reduce unnecessary working directory confusion, switch to
dart pub get -Cinstead ofcdfollowed bydart pub getfor initializing the tooling. (Also makes the same change to the tool README, because why not have humans run one command instead of three.)