[many] Update compileOptions to use Java 17 by reidbaker · Pull Request #10186 · flutter/packages

reidbaker · 2025-10-07T20:54:22Z

Fixes #flutter/flutter/issues/176027

Reviewers be sure to checkout script/tool/lib/src/gradle_check_command.dart which is a tools change.

update tool
update compile options to java 17
Update min flutter version
Update changelog and yamls

Pre-Review Checklist

reidbaker · 2025-10-07T20:54:44Z

Will get an approval then handle merge conflicts.

domesticmouse

LGTM for Flutter SVG

gemini-code-assist

Code Review

This pull request updates a large number of packages to use Java 17, which includes updating build.gradle files, pubspec.yaml files, and CHANGELOG.md files. The changes are mostly consistent, but I've found a few areas for improvement.

My review focuses on:

Ensuring consistency in the jvmTarget setting in build.gradle files.
Pointing out inconsistencies and redundancies in the CHANGELOG.md files.

Overall, the changes look good and are a welcome update. Addressing the minor issues I've pointed out will improve the consistency and clarity of the codebase.

gemini-code-assist · 2025-10-07T20:57:50Z

packages/shared_preferences/shared_preferences_android/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.5.0
+
+* Updates Java compatibility version to 17.


The changelog for version 2.4.14 already mentions the update to Java 17. This new entry for 2.5.0 seems redundant. Please remove it to avoid confusion.

gemini-code-assist · 2025-10-07T20:57:50Z

packages/webview_flutter/webview_flutter_android/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 4.11.0
+
+* Updates Java compatibility version to 17.


The changelog for version 4.10.3 already mentions the update to Java 17. This new entry for 4.11.0 seems redundant. Please remove it to avoid confusion.

gemini-code-assist · 2025-10-07T20:57:50Z

packages/google_fonts/example/android/app/build.gradle


    kotlinOptions {
-        jvmTarget = '11'
+        jvmTarget = JavaVersion.VERSION_17


For consistency with other build.gradle files in this PR, please use JavaVersion.VERSION_17.toString() for the jvmTarget. Most other files use this format.

jvmTarget = JavaVersion.VERSION_17.toString()

gemini-code-assist · 2025-10-07T20:57:50Z

packages/interactive_media_ads/android/build.gradle


    kotlinOptions {
-        jvmTarget = '11'
+        jvmTarget = JavaVersion.VERSION_17


For consistency with other build.gradle files in this PR, please use JavaVersion.VERSION_17.toString() for the jvmTarget. Most other files use this format.

jvmTarget = JavaVersion.VERSION_17.toString()

gemini-code-assist · 2025-10-07T20:57:50Z

packages/rfw/example/local/android/app/build.gradle


    kotlinOptions {
-        jvmTarget = '11'
+        jvmTarget = JavaVersion.VERSION_17


For consistency with other build.gradle files in this PR, please use JavaVersion.VERSION_17.toString() for the jvmTarget. Most other files use this format.

jvmTarget = JavaVersion.VERSION_17.toString()

gemini-code-assist · 2025-10-07T20:57:50Z

packages/shared_preferences/shared_preferences/CHANGELOG.md

+## 2.6.0

-* Updates minimum supported SDK version to Flutter 3.29/Dart 3.7.
+* Updates Java compatibility version to 17. If required, Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.


For consistency with other changelogs in this PR, please split this entry into two separate bullet points, like so:

* Updates Java compatibility version to 17. * If required, Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.

jesswrd

Thanks again for agreeing to let this land first: #10187. Sorry for raining on your parade :0.

stuartmorgan-g · 2025-10-08T17:38:43Z

packages/animations/CHANGELOG.md


-* Updates minimum supported SDK version to Flutter 3.29/Dart 3.7.
+* Updates Java compatibility version to 17.
+* If required, Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.


The "If required" is kind of confusing for a client-facing message. If you don't want to manually trim the line out of the packages that don't need it, I would just say "Sets minimum supported SDK version to Flutter 3.35/Dart 3.9."

If required was so that I could have the same message in all changelogs and handled the case where some plugins had already bumped to 3.35.

stuartmorgan-g · 2025-10-08T17:43:20Z

packages/camera/camera_android/pubspec.yaml

 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22

-version: 0.10.10+8
+version: 0.10.11


0.10.10+1? I would expect this to be a bugfix version bump for everything, is that not the case?

stuartmorgan-g · 2025-10-08T17:45:13Z

packages/file_selector/file_selector/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.0


This definitely shouldn't be a minor version bump; it's only changing example and test code.

(This is probably more manual tweaking than you want to do, but policywise it would be fine to skip changelog and version updates on the packages where the only change is to example and test code. The tool will think you need to version it because lib/main.dart is changing, but updating the autoformat version on pub.dev is not actually something that matters.)

When making package wide changes I would only do that if the tooling had a way to figure that out for me.

We expect all changes in this PR to be a no-op for clients thought, right? I would version all of them as a bugfix, not minor, if that's the case; no package switching required.

stuartmorgan-g · 2025-10-08T17:48:52Z

packages/file_selector/file_selector/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.0
+
+* Updates Java compatibility version to 17.


Optional since it's manual work, but ideally this line should be removed from every package except the Android plugin implementation packages, since changing the Java version that example app uses is not a package-client-affecting change.

stuartmorgan-g · 2025-10-08T17:55:32Z

packages/file_selector/file_selector/CHANGELOG.md

+## 1.1.0
+
+* Updates Java compatibility version to 17.
+* If required, Updates minimum supported SDK version to Flutter 3.35/Dart 3.9.


Actually, here's something we could consider: I'd be fine with changing the Java version used in just the example app without changing the min SDK version. Technically this means someone could fail to build an example app that it looks like they should be able to but this would only happen:

if someone is checking out the repo and building the example app in the first place, which I believe to be quite rare outside of contributors, and

they are using an old version of Flutter, which is very unlikely for contributors, and

they are using an old version of Java.

So an option here would be reverting the changes in this PR for all packages where the only gradle change is in example/, and then doing a second PR for just the examples that only changes the Java version, and has no versioning, no changelog, no min SDK updates (and thus reformatting), etc.

I dont have a strong opinion on the order these things happen I just want to move to java 17 in the gradle files.

I would really like if I could use the same changelog entry for all packages and if I could ship a new version for all packages but I will do whatever you want.

Based on the comment above and @jesswrd pr that updated most packages for gradle 9 I will start this process over from scratch but invert the order. Start with the examples then try to land a pr that has tooling enforcement and the formatting and version bump changes.

Part 1/2 for flutter/flutter/issues/176027 CHANGELOG exemption: Example apps only. #10186 (comment) Tool test will come in part 2 after the non examples have been updated. ## Pre-Review Checklist

reidbaker added 4 commits October 7, 2025 16:31

update tool

d5dc784

update compile options to java 17

b001f9d

Update min flutter version

49d9d9a

Update changelog and yamls

c8a73ba

reidbaker requested review from Hixie, Piinks, ash2moon, bparrishMines, camsim99, chunhtai, domesticmouse, gmackall, hannah-hyj, jesswrd, mboetger, stuartmorgan-g and tarrinneal as code owners October 7, 2025 20:54

github-actions bot added p: path_provider platform-android p: webview_flutter p: video_player p: shared_preferences p: interactive_media_ads Plugin for IMA SDK p: flutter_svg p: google_fonts labels Oct 7, 2025

domesticmouse approved these changes Oct 7, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 7, 2025

View reviewed changes

Add tests for tool change

e857988

jesswrd approved these changes Oct 7, 2025

View reviewed changes

reidbaker mentioned this pull request Oct 8, 2025

Add Versioning to Gradle 9 Deprecation Change #10187

Merged

11 tasks

reidbaker added 3 commits October 8, 2025 10:35

Dart formatting

9c50f2a

update-excerpts

63b1870

move comments explaining why lints are ignored

5988827

github-actions bot added the platform-ios label Oct 8, 2025

reidbaker added 2 commits October 8, 2025 11:58

Bump version in api delegate files

548bfb3

Update version for pigeon

1b2c15f

stuartmorgan-g reviewed Oct 8, 2025

View reviewed changes

reidbaker closed this Oct 8, 2025

reidbaker mentioned this pull request Oct 9, 2025

[many} Update all examples apps to use java 17 complile options #10195

Merged

11 tasks

		@@ -1,3 +1,8 @@
		## 2.5.0

		* Updates Java compatibility version to 17.

		@@ -1,3 +1,8 @@
		## 4.11.0

		* Updates Java compatibility version to 17.

		@@ -1,3 +1,8 @@
		## 1.1.0

		* Updates Java compatibility version to 17.

Conversation

reidbaker commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

reidbaker commented Oct 7, 2025

Uh oh!

domesticmouse left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jesswrd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reidbaker commented Oct 7, 2025 •

edited

Loading